ObjectStorage without chunk-encoding support corrupts files (the action_runner log cannot be viewed)

[OAMchronicle]

Description

actions.ReadLogs, zstd NewSeekableReader: failed to parse footer [52 98 55 51 101 13 10 13 10]: footer reserved bits 25 != 0
Gitea版本: 1.23.3

Gitea Version

1.23.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

use system

Database

MySQL/MariaDB

[OAMchronicle]

My S3 provider is seaweed

[wxiaoguang]

Might be related to Support compression for Actions logs #31761

[wolfogre]

Does it happen for any logs of action runs, or only this log?

It seems that the file is broken for some reasons.

[wxiaoguang]

It seems to be a plain-text file? The foot bytes (from log) are 4b73e\r\n\r\n

[OAMchronicle]

// file gitea/modules/actions/log_test.go
This is the test case I wrote

package actions

import (
	"code.gitea.io/gitea/modules/zstd"
	"fmt"
	"io"
	"os"
	"testing"
)

func TestTransferLogs(t *testing.T) {
	name := "1131.log"
	f, err := os.Open(name)
	if err != nil {
		return
	}
	defer f.Close()
	var reader io.Reader = f

	r, w := io.Pipe()
	reader = r
	zstdWriter, err := zstd.NewSeekableWriter(w, logZstdBlockSize)
	if err != nil {
		fmt.Errorf("zstd NewSeekableWriter: %w", err)
	}
	go func() {
		defer func() {
			_ = w.CloseWithError(zstdWriter.Close())
		}()
		if _, err := io.Copy(zstdWriter, f); err != nil {
			_ = w.CloseWithError(err)
			return
		}
	}()
	file, err := os.OpenFile("1131.log.zst", os.O_CREATE|os.O_RDWR, 0666)
	if err != nil {
		return
	}
	defer file.Close()
	_, err = io.Copy(file, reader)
	if err != nil {
		return
	}
	/*
		minioStorage, err := storage.NewMinioStorage(context.Background(),
			&setting.Storage{
				MinioConfig: setting.MinioStorageConfig{
					Endpoint:           "x.x.x.x:8333",
					AccessKeyID:        "xxx",
					SecretAccessKey:    "xxx",
					Bucket:             "gitea",
					UseSSL:             false,
					InsecureSkipVerify: true,
				},
			})
		if err != nil {
			return
		}
		_, err = minioStorage.Save("logs/1131.log.zst", reader, -1)
		if err != nil {
			return
		}
	*/
}

There is no problem when using local files. This issue will be triggered when uploading to S3

[OAMchronicle]

Does it happen for any logs of action runs, or only this log?

It seems that the file is broken for some reasons.

Currently, I know it's a log

[wxiaoguang]

Will the S3 storage auto decompress the compressed zstd files and respond plain-text?

[OAMchronicle]

I don't know, I don't think it will happen. The S3 I am using is seaweed

[wxiaoguang]

It seems to be a plain-text file? The first bytes (from log) are 4b73e\r\n\r\n

According to your log, the response is plain-text.

Could you help to confirm the seaweed's behavior? For example: use your test code , and read the logs/1131.log.zst raw content and dump it to see whether it is compressed or decompressed? (or: maybe the response is jut incorrect? just a guess)

[OAMchronicle]

1131.log.obs.zst is directly uploaded to S3 based on the test code。
1131. log.zst is manually uploaded to S3 based on the test code saved locally

[OAMchronicle]

func TestTransferLogs1(t *testing.T) {
	open, err := os.Open("1131.log.zst")
	if err != nil {
		return
	}
	minioStorage, err := storage.NewMinioStorage(context.Background(),
		&setting.Storage{
			MinioConfig: setting.MinioStorageConfig{
				Endpoint:           "x.x.x.x:8333",
				AccessKeyID:        "xx",
				SecretAccessKey:    "xx",
				Bucket:             "gitea",
				UseSSL:             false,
				InsecureSkipVerify: true,
			},
		})
	if err != nil {
		return
	}
	_, err = minioStorage.Save("logs/1131.log.local.zst", open, -1)
	if err != nil {
		return
	}
}

After testing, it seems that Seaweed encountered an exception during upload

[wxiaoguang]

Thank you for the feedback! I didn't quite use Actions or Seaweed, so at the moment, I have no more idea.

If you could help to figure out "what's wrong" (the key point, for example: is it Gitea's bug? which call/code is wrong; or Seaweed's problem? what's the difference), then maybe there could be some solutions to "fix".