PR acceptance blocked for PR creator

[lucasfantacuci]

• Gitea version (or commit ref): 1.2.3

Description

Our development team was thinking to use PR system to review our code, is there any feature to block the creator of the PR to accept it?

Screenshots

On that example, the user administrator created de PR and accepted it.

[mbger]

Right now, I don't think so. Probably only possible when #2794 is done. But correct me if I'm wrong.

[thehowl]

I'm pretty sure that you can set a collaborator's permission to 'Read', and that should grant them ability to make PRs & such, but not push directly. Although, of course, a repo admin / someone with write access would be needed to merge the PR.

[lunny]

resolved by #3689

[cailyoung]

@lunny this is not resolved by #3689 - if the PR creator is on the whitelist they can merge. #2794 was abandoned. Is there any other issue in progress that would deliver this?

[lafriks]

@cailyoung you can set that PR needs at least one approval

[lunny]

@lafriks 's idea is correct.

[cailyoung]

@lafriks @lunny

Apologies, we are not running 1.6.0 or newer. I will have a chat with the team here.

[cailyoung]

So #3748 fixes this - i.e. the PR creator cannot be an approver?

[lunny]

@cailyoung yes, one could not approve himself PR.