No button to merge PR

[AntouanK]

• Gitea version (or commit ref): a2a49c9
• Git version: 2.15.0
• Operating system: docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Cannot merge PR anymore!
I pulled the latest docker image earlier today.
Now, when I open a PR in any private repo, there's no button to merge it! Am I missing something?
Seems like it's related to this commit a2a49c9 ?

Screenshots

[lafriks]

Is master branch protected?

[AntouanK]

Yes, and develop. But from direct commits. Not PRs
I had it like that in previous versions and it worked fine.

[lunny]

Do you in whitelist on protected branch?

[AntouanK]

No, I didn't add anything in the whitelist.

[lunny]

Yes. #3544 ask you have to add the people who has permission to merge pull request, not repo writers any more.

[lafriks]

@lunny this should probably be changed if noone is specified in whitelist than everyone can merge, otherwise it will break a lot of instances

[lunny]

We need a migration?

[lafriks]

@lunny no just add if non are defined than everyone with write rights can merge

[lunny]

@lafriks but that's conflict with the push policy.