Error on startup 1.5

[ymabispo]

• Gitea version (or commit ref): 1.5
• Git version: 2.17.1
• Operating system: Windows Server 2008 R2 Standard
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Guys, a few minutes ago a tried to update 1.4.3 to 1.5 and the windows service doesn't start up.
log error:

2018/07/04 07:56:23 [I] Log Mode: File(Trace)
2018/07/04 07:56:23 [I] XORM Log Mode: File(Trace)
2018/07/04 07:56:23 [I] Cache Service Enabled
2018/07/04 07:56:23 [I] Session Service Enabled
2018/07/04 07:56:23 [I] Migration: add multiple assignees
2018/07/04 07:56:23 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: Drop table issue columns [assignee_id]: mssql: ALTER TABLE DROP COLUMN assignee_id failed because one or more objects access this column.
...

Screenshots

[lunny]

The CI for MSSQL could be added by #4282

[lafriks]

@ymabispo can you check if code from pull request #4440 fixes your problem?

[bjoe2k4]

@lafriks I'm seeing a similar problem after updating from 1.4.1 to git-master, but with mysql.

[I] Gitea v8e103d3 built with: bindata, sqlite
[...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: Drop table `issue` columns [assignee_id]: sql: Transaction has already been committed or rolled back```

[back2root]

@lafriks I guess commit e95417e fixes an issue for MSSQL but introduces an issue for MySQL.

I do see a similar problem as @bjoe2k4 but with migrating db v69 -> 70 as it seems that I'm already on a newer DB Version.

Error Message I get on first Start:

2018/07/17 20:29:18 [I] Migration: move team units to team_unit table
2018/07/17 20:29:19 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: Drop table team columns [unit_types]: sql: Transaction has already been committed or rolled back

Subsequent Starts will log (just in case anyone is googling for this error):

2018/07/17 20:37:42 [I] Migration: move team units to team_unit table
2018/07/17 20:37:42 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: Insert team units: Error 1062: Duplicate entry '1-1' for key 'UQE_team_unit_s'

My first guess is that we simply need to open a new session:

Insert (after committing session):

sess.Close()
sess := x.NewSession()
defer sess.Close()

[back2root]

If PR #4459 get's accepted and you still get the following error:

2018/07/17 20:37:42 [I] Migration: move team units to team_unit table
2018/07/17 20:37:42 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: Insert team units: Error 1062: Duplicate entry '1-1' for key 'UQE_team_unit_s'

you may simply "drop table team_unit" and restart gitea.