Skip to content

Allow Repo Administrators to (Force) Merge "Review Required" PRs #8272

Closed
@bagasme

Description

@bagasme
  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    (not relevant)

Description

In cases whether there is an open PR against protected branch that requires approved reviews from whitelisted reviewers, and all reviewers aren't available in time, repo administrators can still merge that PR. An example when this feature is useful is when a PR contains important security fixes.

Screenshots

This screenshot is from my localhost Gitea instance on a computer. A user (which is repo administrator) open a PR against protected branch (master). Required approvals are 1. However, despite that he is an admin, he can't (force) merge his PR without approvals. That is, there isn't Merge Pull Request button.
image
On the other hand, on GitHub, there is Merge Pull Request button which allows admins to merge
PR without review approvals (that is, force merging).
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions