Repository redirect not use modified `ROOT_URL`

[tomac4t]

• Gitea version (or commit ref): 1.10.0-rc1 from binary: https://dl.gitea.io/gitea/1.10.0-rc1/gitea-1.10.0-rc1-linux-amd64
• Git version: git version 2.20.1
• Operating system: GNU/Linux Debian 10
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No (ROOT_URL value is different.)
  • Not relevant
• Log gist:

Description

I install Gitea under a sub-path /git/ with Nginx as a reverse proxy.

When I modified "repository name", the old repo link should be redirected to the new link. I am expected it redirect to /git/<OwnerNAME>/<RepoName>/, but it actually redirect to /<OwnerNAME>/<RepoName>/.

app.ini:

[server]
PROTOCOL         = http
SSH_DOMAIN       = localhost
DOMAIN           = localhost
HTTP_ADDR        = 127.0.0.1
HTTP_PORT        = 8000
ROOT_URL         = https://example.com/git/
DISABLE_SSH      = true
LFS_START_SERVER = true
LFS_CONTENT_PATH = /var/lib/gitea/data/lfs
[...]

nginx.conf:

location ^~/git/ {
    proxy_pass http://localhost:8000/;
}
[...]

Screenshots

[zeripath]

So redirects are managed by this code:

gitea/modules/context/repo.go

Lines 219 to 240 in 1b72690

	// RedirectToRepo redirect to a differently-named repository
	func RedirectToRepo(ctx *Context, redirectRepoID int64) {
	ownerName := ctx.Params(":username")
	previousRepoName := ctx.Params(":reponame")
	repo, err := models.GetRepositoryByID(redirectRepoID)
	if err != nil {
	ctx.ServerError("GetRepositoryByID", err)
	return
	}
	redirectPath := strings.Replace(
	ctx.Req.URL.Path,
	fmt.Sprintf("%s/%s", ownerName, previousRepoName),
	fmt.Sprintf("%s/%s", repo.MustOwnerName(), repo.Name),
	1,
	)
	if ctx.Req.URL.RawQuery != "" {
	redirectPath += "?" + ctx.Req.URL.RawQuery
	}
	ctx.Redirect(redirectPath)
	}

Which basically does a straight replacement of the path that it is given.

Adding the setting.AppSubUrl to the path at

gitea/modules/context/repo.go

Line 239 in 1b72690

ctx.Redirect(redirectPath)

should be enough to make this work but it could do with some checking

[6543]

@zeripath is there a PR you are working on right now?

[zeripath]

Nope I just read the comment and realised how to fix it before bed. I won't really get a chance to look at this until evening UK time today so if you or anyone else fancies it in the meantime - please do send the PR.