Provide self-registering storage system #12978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
the
type/refactoring
Codecov Report
@@ Coverage Diff @@
## master #12978 +/- ##
==========================================
- Coverage 42.62% 42.61% -0.01%
==========================================
Files 672 673 +1
Lines 73785 73797 +12
==========================================
+ Hits 31448 31452 +4
+ Misses 37247 37244 -3
- Partials 5090 5101 +11
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
lunny/storage_config-self-register
branch
from
6d908b3 to
7f2f6fe
Compare
lafriks
approved these changes
Oct 5, 2020
GiteaBot
added
lgtm/need 1
|
Please resolve conflicts ;) |
|
conflicts resolved |
|
@lunny please review |
lunny
reviewed
Oct 11, 2020
lunny
reviewed
Oct 11, 2020
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12978 +/- ##
==========================================
+ Coverage 42.25% 42.35% +0.10%
==========================================
Files 675 676 +1
Lines 74520 74532 +12
==========================================
+ Hits 31485 31569 +84
+ Misses 37922 37826 -96
- Partials 5113 5137 +24
Continue to review full report at Codecov.
|
6543
approved these changes
Oct 12, 2020
GiteaBot
added
lgtm/done
|
failed unrelated |
techknowlogick
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a continuation of some work on #12813.
It provides for a self-registering storage solution and means that we can (mostly) avoid changing code outside of modules/storage if we add a storage system.
I think there is an extension to this to do with the default mapping and further improvements to do with default settings but this gives the first steps for this.
Signed-off-by: Andrew Thornton [email protected]