-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Dockerfile: Support socat use cases #13208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In some contexts it is necessary to provide access to Gitea via TCP ports and unix sockets. Gitea (`gitea web`) can be configured to listen for connections via unix-socket or TCP port, but not both. When Gitea is installed to the host this limitation can be worked around by installing socat on the host. When running Gitea from a container this limitation cannot be workaround. Add socat to Gitea container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, just wondering why such a specific version of socat?
Our practice to try eliminate surprises, and socat has that versioning convention. |
It does not build as alpine has |
Codecov Report
@@ Coverage Diff @@
## master #13208 +/- ##
=======================================
Coverage 42.16% 42.17%
=======================================
Files 684 684
Lines 75540 75540
=======================================
+ Hits 31851 31856 +5
+ Misses 38465 38462 -3
+ Partials 5224 5222 -2
Continue to review full report at Codecov.
|
🚀 |
I think we should revert this commit for security reason. This is not a big security risk but we shouldn't make it more easy for an attacker by default. |
This reverts commit ff50274.
☝️ because of #13369 |
In some contexts it is necessary to provide access to Gitea via TCP ports and unix sockets.
Gitea (
gitea web
) can be configured to listen for connections via unix-socket or TCP port, but not both.When Gitea is installed to the host this limitation can be worked around by installing socat on the host.
When running Gitea from a container this limitation cannot be workaround.
Add socat to Gitea container.