-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Propagate changes of md-rendered checkboxes to the server #14258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
face387
Propagate changes of md-rendered checkboxes on an issue page to the s…
6e824dc
Make it work for in any comment block
45b9bf5
Merge branch 'master' into 7097
6543 4ac7ad5
More consistent variable naming
157656c
Merge branch 'master' into 7097
6543 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
const checkboxMarkdownPattern = /\[[ x]]/g; | ||
|
||
/** | ||
* Attaches `change` handlers to markdown rendered checkboxes in comments. | ||
* When a checkbox value changes, the corresponding [ ] or [x] in the markdown string is set accordingly and sent to the server. | ||
* On success it updates the raw-content on error it resets the checkbox to its original value. | ||
*/ | ||
export default function initMarkdownCheckboxes() { | ||
$('.comment .segment').each((_, segment) => { | ||
const $segment = $(segment); | ||
const $checkboxes = $segment.find('.render-content.markdown input:checkbox'); | ||
|
||
const onChange = async (ev, cbIndex) => { | ||
const $cb = $(ev.target); | ||
const checkboxMarkdown = $cb.is(':checked') ? '[x]' : '[ ]'; | ||
|
||
const $rawContent = $segment.find('.raw-content'); | ||
const oldContent = $rawContent.text(); | ||
const newContent = oldContent.replace(checkboxMarkdownPattern, replaceNthMatchWith(cbIndex, checkboxMarkdown)); | ||
|
||
if (newContent !== oldContent) { | ||
disableAll($checkboxes); | ||
|
||
try { | ||
const url = $segment.find('.edit-content-zone').data('update-url'); | ||
const context = $segment.find('.edit-content-zone').data('context'); | ||
|
||
await submit(newContent, url, context); | ||
$rawContent.text(newContent); | ||
} catch (e) { | ||
$cb.prop('checked', !$cb.is(':checked')); | ||
|
||
console.error(e); | ||
} finally { | ||
enableAll($checkboxes); | ||
} | ||
} | ||
}; | ||
|
||
enableAll($checkboxes); | ||
$checkboxes.each((cbIndex, cb) => { | ||
$(cb).on('change', (ev) => onChange(ev, cbIndex)); | ||
}); | ||
}); | ||
} | ||
|
||
function enableAll ($checkboxes) { $checkboxes.removeAttr('disabled') } | ||
function disableAll ($checkboxes) { $checkboxes.attr('disabled', 'disabled') } | ||
|
||
function submit (content, url, context) { | ||
const csrf = window.config.csrf; | ||
|
||
return $.post(url, { | ||
_csrf: csrf, | ||
context, | ||
content, | ||
}); | ||
} | ||
|
||
function replaceNthMatchWith(n, replaceWith) { | ||
let matchIndex = 0; | ||
|
||
return (match) => { | ||
if (n === matchIndex++) { | ||
return replaceWith; | ||
} | ||
|
||
return match; | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.