Skip to content

Add support to migrate from gogs #14342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Jan 21, 2021
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
5f3196f
add support to migrate from gogs
lunny Jun 11, 2019
21533a4
remove test since it depends on try.gogs.io
lunny Jul 8, 2019
78d75c5
handle unsupported error
lunny Jul 8, 2019
7417afd
fix vendor
lunny Jul 9, 2019
efcf78d
fix go.sum
lunny Nov 3, 2019
9fe0b4a
ignore gogs test since it depends on try.gogs.io
lunny Nov 3, 2019
64b371a
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 14, 2021
93a97ad
adapt: 'migrate service type switch page'
6543 Jan 14, 2021
e34e6c2
refactor & fix & update
6543 Jan 14, 2021
2da5710
fix
6543 Jan 14, 2021
2b890ff
optimize svg
6543 Jan 14, 2021
dc5e3ba
refactor IsErrNotSupported
6543 Jan 14, 2021
f509a1d
gogs dont support oauth2
6543 Jan 14, 2021
0dda8a9
Update modules/migrations/migrate.go
6543 Jan 14, 2021
8845c23
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 14, 2021
9225b0b
fix lint
6543 Jan 14, 2021
f8635eb
refactor migrations downloader interface implementation(s)
6543 Jan 15, 2021
7518582
fix lint
6543 Jan 15, 2021
bb6512e
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 15, 2021
bce51d1
handle ErrNotSupported on all downloader functions ...
6543 Jan 15, 2021
cf30f4f
more specific error messages
6543 Jan 15, 2021
07d3691
RetryDownloader: dont retry if not supported
6543 Jan 15, 2021
41be205
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 16, 2021
5d7dc8d
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 16, 2021
f8159e7
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 16, 2021
4bbb5e2
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 16, 2021
98fa152
fix generate CloneURL
6543 Jan 16, 2021
53f40f9
gogs: migrate closed issues too
6543 Jan 16, 2021
67f9344
optimize
6543 Jan 16, 2021
9a3e37d
sdk bug detected :/
6543 Jan 16, 2021
d70c62e
resolve TODO
6543 Jan 16, 2021
15f3307
fix out of slice issue
6543 Jan 17, 2021
aa6b837
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 17, 2021
4099e17
fix pagination
6543 Jan 17, 2021
b6559cf
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 17, 2021
08b9e41
Resolve GetTopics() TODO
6543 Jan 17, 2021
c177145
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 17, 2021
72bd6de
impruve more
6543 Jan 17, 2021
df0e55a
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 18, 2021
7ecc980
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 18, 2021
f033f5e
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 18, 2021
16dc498
nits
6543 Jan 19, 2021
6cd3cde
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 19, 2021
802b532
fix get Comments
6543 Jan 19, 2021
c024e5d
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 19, 2021
b6761e6
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 19, 2021
270cabf
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 19, 2021
1ecb88c
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 20, 2021
5a5134d
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 20, 2021
9b7ff34
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 21, 2021
f1cbea2
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 21, 2021
e6e7752
Merge branch 'master' into lunny/downloader_gogs
6543 Jan 21, 2021
e9109dd
Retrofit context cancellation
zeripath Jan 21, 2021
19e2ed8
Update modules/migrations/gogs.go
zeripath Jan 21, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ require (
github.com/gobwas/glob v0.2.3
github.com/gogs/chardet v0.0.0-20191104214054-4b6791f73a28
github.com/gogs/cron v0.0.0-20171120032916-9f6c956d3e14
github.com/gogs/go-gogs-client v0.0.0-20200905025246-8bb8a50cb355
github.com/google/go-github/v32 v32.1.0
github.com/google/uuid v1.1.2
github.com/gorilla/context v1.1.1
Expand Down
57 changes: 4 additions & 53 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion modules/migrations/base/milestone.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ type Milestone struct {
Created time.Time
Updated *time.Time
Closed *time.Time
State string
State string // open, closed
}
5 changes: 5 additions & 0 deletions modules/migrations/error.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ var (
ErrRepoNotCreated = errors.New("repository is not created yet")
)

// IsErrNotSupported returns true if the err is ErrNotSupported
func IsErrNotSupported(err error) bool {
return err == ErrNotSupported
}

// IsRateLimitError returns true if the err is github.RateLimitError
func IsRateLimitError(err error) bool {
_, ok := err.(*github.RateLimitError)
Expand Down
11 changes: 7 additions & 4 deletions modules/migrations/gitea_uploader.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,22 @@ func (g *GiteaLocalUploader) MaxBatchInsertSize(tp string) int {
}

func fullURL(opts base.MigrateOptions, remoteAddr string) (string, error) {
var fullRemoteAddr = remoteAddr
if len(opts.AuthToken) > 0 || len(opts.AuthUsername) > 0 {
u, err := url.Parse(remoteAddr)
if err != nil {
return "", err
}
u.User = url.UserPassword(opts.AuthUsername, opts.AuthPassword)
if len(opts.AuthToken) > 0 {
u.User = url.UserPassword("oauth2", opts.AuthToken)
if opts.GitServiceType == structs.GogsService {
u.User = url.UserPassword(opts.AuthToken, "")
} else {
u.User = url.UserPassword("oauth2", opts.AuthToken)
}
}
fullRemoteAddr = u.String()
return u.String(), nil
}
return fullRemoteAddr, nil
return remoteAddr, nil
}

// CreateRepo creates a repository
Expand Down
263 changes: 263 additions & 0 deletions modules/migrations/gogs.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,263 @@
// Copyright 2019 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package migrations

import (
"context"
"fmt"
"net/http"
"net/url"
"strings"
"time"

"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/migrations/base"
"code.gitea.io/gitea/modules/structs"

"github.com/gogs/go-gogs-client"
)

var (
_ base.Downloader = &GogsDownloader{}
_ base.DownloaderFactory = &GogsDownloaderFactory{}
)

func init() {
RegisterDownloaderFactory(&GogsDownloaderFactory{})
}

// GogsDownloaderFactory defines a gogs downloader factory
type GogsDownloaderFactory struct {
}

// New returns a Downloader related to this factory according MigrateOptions
func (f *GogsDownloaderFactory) New(ctx context.Context, opts base.MigrateOptions) (base.Downloader, error) {
u, err := url.Parse(opts.CloneAddr)
if err != nil {
return nil, err
}

baseURL := u.Scheme + "://" + u.Host
fields := strings.Split(u.Path, "/")
oldOwner := fields[1]
oldName := strings.TrimSuffix(fields[2], ".git")

log.Trace("Create gogs downloader: %s/%s", oldOwner, oldName)

return NewGogsDownloader(ctx, baseURL, opts.AuthUsername, opts.AuthPassword, opts.AuthToken, oldOwner, oldName), nil
}

// GitServiceType returns the type of git service
func (f *GogsDownloaderFactory) GitServiceType() structs.GitServiceType {
return structs.GogsService
}

// GogsDownloader implements a Downloader interface to get repository informations
// from gogs via API
type GogsDownloader struct {
ctx context.Context
client *gogs.Client
baseURL string
repoOwner string
repoName string
userName string
password string
}

func (g *GogsDownloader) SetContext(ctx context.Context) {
g.ctx = ctx
}

// NewGogsDownloader creates a gogs Downloader via gogs API
func NewGogsDownloader(ctx context.Context, baseURL, userName, password, token, repoOwner, repoName string) *GogsDownloader {
var downloader = GogsDownloader{
ctx: ctx,
baseURL: baseURL,
userName: userName,
password: password,
repoOwner: repoOwner,
repoName: repoName,
}

var client *gogs.Client
if len(token) != 0 {
client = gogs.NewClient(baseURL, token)
downloader.userName = token
} else {
client = gogs.NewClient(baseURL, "")
client.SetHTTPClient(&http.Client{
Transport: &http.Transport{
Proxy: func(req *http.Request) (*url.URL, error) {
req.SetBasicAuth(userName, password)
return nil, nil
},
},
})
}

downloader.client = client
return &downloader
}

// GetRepoInfo returns a repository information
func (g *GogsDownloader) GetRepoInfo() (*base.Repository, error) {
gr, err := g.client.GetRepo(g.repoOwner, g.repoName)
if err != nil {
return nil, err
}

// convert gogs repo to stand Repo
return &base.Repository{
Owner: g.repoOwner,
Name: g.repoName,
IsPrivate: gr.Private,
Description: gr.Description,
CloneURL: gr.CloneURL,
OriginalURL: gr.HTMLURL,
DefaultBranch: gr.DefaultBranch,
}, nil
}

// GetMilestones returns milestones
func (g *GogsDownloader) GetMilestones() ([]*base.Milestone, error) {
var perPage = 100
var milestones = make([]*base.Milestone, 0, perPage)

ms, err := g.client.ListRepoMilestones(g.repoOwner, g.repoName)
if err != nil {
return nil, err
}

t := time.Now()

for _, m := range ms {
milestones = append(milestones, &base.Milestone{
Title: m.Title,
Description: m.Description,
Deadline: m.Deadline,
State: string(m.State),
Created: t,
Updated: &t,
Closed: m.Closed,
})
}

return milestones, nil
}

// GetLabels returns labels
func (g *GogsDownloader) GetLabels() ([]*base.Label, error) {
var perPage = 100
var labels = make([]*base.Label, 0, perPage)
ls, err := g.client.ListRepoLabels(g.repoOwner, g.repoName)
if err != nil {
return nil, err
}

for _, label := range ls {
labels = append(labels, convertGogsLabel(label))
}

return labels, nil
}

// GetIssues returns issues according start and limit, perPage is not supported
func (g *GogsDownloader) GetIssues(page, perPage int) ([]*base.Issue, bool, error) {
var allIssues = make([]*base.Issue, 0, perPage)

issues, err := g.client.ListRepoIssues(g.repoOwner, g.repoName, gogs.ListIssueOption{
Page: page,
})
if err != nil {
return nil, false, fmt.Errorf("error while listing repos: %v", err)
}
for _, issue := range issues {
if issue.PullRequest != nil {
continue
}

allIssues = append(allIssues, convertGogsIssue(issue))
}

return allIssues, len(issues) == 0, nil
}

// GetComments returns comments according issueNumber
func (g *GogsDownloader) GetComments(issueNumber int64) ([]*base.Comment, error) {
var allComments = make([]*base.Comment, 0, 100)

comments, err := g.client.ListIssueComments(g.repoOwner, g.repoName, issueNumber)
if err != nil {
return nil, fmt.Errorf("error while listing repos: %v", err)
}
for _, comment := range comments {
allComments = append(allComments, &base.Comment{
PosterName: comment.Poster.Login,
PosterEmail: comment.Poster.Email,
Content: comment.Body,
Created: comment.Created,
Updated: comment.Updated,
})
}

return allComments, nil
}

func convertGogsIssue(issue *gogs.Issue) *base.Issue {
var milestone string
if issue.Milestone != nil {
milestone = issue.Milestone.Title
}
var labels = make([]*base.Label, 0, len(issue.Labels))
for _, l := range issue.Labels {
labels = append(labels, convertGogsLabel(l))
}

var closed *time.Time
if issue.State == gogs.STATE_CLOSED {
// gogs client haven't provide closed, so we use updated instead
closed = &issue.Updated
}

return &base.Issue{
Title: issue.Title,
Number: issue.Index,
PosterName: issue.Poster.Login,
PosterEmail: issue.Poster.Email,
Content: issue.Body,
Milestone: milestone,
State: string(issue.State),
Created: issue.Created,
Labels: labels,
Closed: closed,
}
}

func convertGogsLabel(label *gogs.Label) *base.Label {
return &base.Label{
Name: label.Name,
Color: label.Color,
}
}

// GetReleases returns releases
// FIXME: gogs API haven't support get releases
func (g *GogsDownloader) GetReleases() ([]*base.Release, error) {
return nil, ErrNotSupported
}

// GetTopics return gogs topics
func (g *GogsDownloader) GetTopics() ([]string, error) {
return nil, ErrNotSupported
}

// GetPullRequests returns pull requests according page and perPage
func (g *GogsDownloader) GetPullRequests(_, _ int) ([]*base.PullRequest, bool, error) {
return nil, false, ErrNotSupported
}

func (g *GogsDownloader) GetReviews(_ int64) ([]*base.Review, error) {
return nil, ErrNotSupported
}
Loading