Skip to content

Sort / move project boards #14634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions models/project_board.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ type ProjectBoard struct {
ID int64 `xorm:"pk autoincr"`
Title string
Default bool `xorm:"NOT NULL DEFAULT false"` // issues not assigned to a specific board will be assigned to this board
Sorting int8 `xorm:"DEFAULT 0"`

ProjectID int64 `xorm:"INDEX NOT NULL"`
CreatorID int64 `xorm:"NOT NULL"`
Expand Down Expand Up @@ -157,15 +158,24 @@ func getProjectBoard(e Engine, boardID int64) (*ProjectBoard, error) {
return board, nil
}

// UpdateProjectBoard updates the title of a project board
// UpdateProjectBoard updates a project board
func UpdateProjectBoard(board *ProjectBoard) error {
return updateProjectBoard(x, board)
}

func updateProjectBoard(e Engine, board *ProjectBoard) error {
_, err := e.ID(board.ID).Cols(
"title",
).Update(board)
var fieldToUpdate []string

if board.Sorting != 0 {
fieldToUpdate = append(fieldToUpdate, "sorting")
}

if board.Title != "" {
fieldToUpdate = append(fieldToUpdate, "title")
}

_, err := e.ID(board.ID).Cols(fieldToUpdate...).Update(board)

return err
}

Expand All @@ -178,7 +188,7 @@ func GetProjectBoards(projectID int64) (ProjectBoardList, error) {
func getProjectBoards(e Engine, projectID int64) ([]*ProjectBoard, error) {
var boards = make([]*ProjectBoard, 0, 5)

if err := e.Where("project_id=? AND `default`=?", projectID, false).Find(&boards); err != nil {
if err := e.Where("project_id=? AND `default`=?", projectID, false).OrderBy("Sorting").Find(&boards); err != nil {
return nil, err
}

Expand Down Expand Up @@ -277,3 +287,17 @@ func (bs ProjectBoardList) LoadIssues() (IssueList, error) {
}
return issues, nil
}

// UpdateProjectBoardSorting update project board sorting
func UpdateProjectBoardSorting(bs ProjectBoardList) error {
for i := range bs {
_, err := x.ID(bs[i].ID).Cols(
"sorting",
).Update(bs[i])

if err != nil {
return err
}
}
return nil
}
8 changes: 4 additions & 4 deletions modules/forms/repo_form.go
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,10 @@ type UserCreateProjectForm struct {
UID int64 `binding:"Required"`
}

// EditProjectBoardTitleForm is a form for editing the title of a project's
// board
type EditProjectBoardTitleForm struct {
Title string `binding:"Required;MaxSize(100)"`
// EditProjectBoardForm is a form for editing a project board
type EditProjectBoardForm struct {
Title string `binding:"Required;MaxSize(100)"`
Sorting int8
}

// _____ .__.__ __
Expand Down
12 changes: 8 additions & 4 deletions routers/repo/projects.go
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ func DeleteProjectBoard(ctx *context.Context) {

// AddBoardToProjectPost allows a new board to be added to a project.
func AddBoardToProjectPost(ctx *context.Context) {
form := web.GetForm(ctx).(*auth.EditProjectBoardTitleForm)
form := web.GetForm(ctx).(*auth.EditProjectBoardForm)
if !ctx.Repo.IsOwner() && !ctx.Repo.IsAdmin() && !ctx.Repo.CanAccess(models.AccessModeWrite, models.UnitTypeProjects) {
ctx.JSON(403, map[string]string{
"message": "Only authorized users are allowed to perform this action.",
Expand Down Expand Up @@ -481,9 +481,9 @@ func checkProjectBoardChangePermissions(ctx *context.Context) (*models.Project,
return project, board
}

// EditProjectBoardTitle allows a project board's title to be updated
func EditProjectBoardTitle(ctx *context.Context) {
form := web.GetForm(ctx).(*auth.EditProjectBoardTitleForm)
// EditProjectBoard allows a project board's to be updated
func EditProjectBoard(ctx *context.Context) {
form := web.GetForm(ctx).(*auth.EditProjectBoardForm)
_, board := checkProjectBoardChangePermissions(ctx)
if ctx.Written() {
return
Expand All @@ -493,6 +493,10 @@ func EditProjectBoardTitle(ctx *context.Context) {
board.Title = form.Title
}

if form.Sorting != 0 {
board.Sorting = form.Sorting
}

if err := models.UpdateProjectBoard(board); err != nil {
ctx.ServerError("UpdateProjectBoard", err)
return
Expand Down
4 changes: 2 additions & 2 deletions routers/routes/web.go
Original file line number Diff line number Diff line change
Expand Up @@ -853,15 +853,15 @@ func RegisterRoutes(m *web.Route) {
m.Get("/new", repo.NewProject)
m.Post("/new", bindIgnErr(auth.CreateProjectForm{}), repo.NewProjectPost)
m.Group("/{id}", func() {
m.Post("", bindIgnErr(auth.EditProjectBoardTitleForm{}), repo.AddBoardToProjectPost)
m.Post("", bindIgnErr(auth.EditProjectBoardForm{}), repo.AddBoardToProjectPost)
m.Post("/delete", repo.DeleteProject)

m.Get("/edit", repo.EditProject)
m.Post("/edit", bindIgnErr(auth.CreateProjectForm{}), repo.EditProjectPost)
m.Post("/{action:open|close}", repo.ChangeProjectStatus)

m.Group("/{boardID}", func() {
m.Put("", bindIgnErr(auth.EditProjectBoardTitleForm{}), repo.EditProjectBoardTitle)
m.Put("", bindIgnErr(auth.EditProjectBoardForm{}), repo.EditProjectBoard)
m.Delete("", repo.DeleteProjectBoard)
m.Post("/default", repo.SetDefaultProjectBoard)

Expand Down
2 changes: 1 addition & 1 deletion templates/repo/projects/view.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<div class="board">
{{ range $board := .Boards }}

<div class="ui segment board-column">
<div class="ui segment board-column" data-id="{{.ID}}" data-sorting="{{.Sorting}}" data-url="{{$.RepoLink}}/projects/{{$.Project.ID}}/{{.ID}}">
<div class="board-column-header">
<div class="ui large label board-label">{{.Title}}</div>
{{if and $.CanWriteProjects (not $.Repository.IsArchived) $.PageIsProjects (ne .ID 0)}}
Expand Down
29 changes: 29 additions & 0 deletions web_src/js/features/projects.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,34 @@ export default async function initProject() {
const {Sortable} = await import(/* webpackChunkName: "sortable" */'sortablejs');
const boardColumns = document.getElementsByClassName('board-column');

new Sortable(
document.getElementsByClassName('board')[0],
{
group: 'board-column',
draggable: '.board-column',
animation: 150,
onSort: () => {
const board = document.getElementsByClassName('board')[0];
const boardColumns = board.getElementsByClassName('board-column');

boardColumns.forEach((column, i) => {
if (parseInt($(column).data('sorting')) !== i) {
$.ajax({
url: $(column).data('url'),
data: JSON.stringify({sorting: i}),
headers: {
'X-Csrf-Token': csrf,
'X-Remote': true,
},
contentType: 'application/json',
method: 'PUT',
});
}
});
},
},
);

for (const column of boardColumns) {
new Sortable(
column.getElementsByClassName('board')[0],
Expand Down Expand Up @@ -74,6 +102,7 @@ export default async function initProject() {

window.location.reload();
});

$('.delete-project-board').each(function () {
$(this).click(function (e) {
e.preventDefault();
Expand Down