Skip to content

Remove spurious set name from eventsource.sharedworker.js #15643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zeripath
Copy link
Contributor

Fix #15617

Signed-off-by: Andrew Thornton [email protected]

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15643 (d2d49fb) into master (1e87761) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15643   +/-   ##
=======================================
  Coverage   43.90%   43.91%           
=======================================
  Files         678      678           
  Lines       81742    81742           
=======================================
+ Hits        35892    35900    +8     
+ Misses      40002    39995    -7     
+ Partials     5848     5847    -1     
Impacted Files Coverage Δ
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
modules/git/repo_commit_nogogit.go 62.50% <0.00%> (+1.56%) ⬆️
modules/git/command.go 89.42% <0.00%> (+1.92%) ⬆️
modules/indexer/stats/db.go 60.71% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e87761...d2d49fb. Read the comment docs.

@techknowlogick techknowlogick merged commit 2c57352 into go-gitea:master Apr 28, 2021
@zeripath zeripath deleted the fix-15617-remove-spurious-set-name branch April 28, 2021 17:20
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 28, 2021
@zeripath zeripath added the backport/done All backports for this PR have been created label Apr 28, 2021
6543 pushed a commit that referenced this pull request Apr 28, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS error thrown in console on all pages: TypeError: setting getter-only property "name"
7 participants