Skip to content

Unify integration test configs #15650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2021
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 28, 2021

I noticed the paths are not unified across the different configs. Some paths were shared too which could cause errors.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2021
@6543 6543 added this to the 1.15.0 milestone May 1, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15650 (0d609b5) into master (67e1039) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15650      +/-   ##
==========================================
+ Coverage   43.90%   43.92%   +0.01%     
==========================================
  Files         678      678              
  Lines       81809    81809              
==========================================
+ Hits        35917    35931      +14     
+ Misses      40045    40031      -14     
  Partials     5847     5847              
Impacted Files Coverage Δ
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
models/gpg_key.go 53.51% <0.00%> (-0.57%) ⬇️
services/pull/pull.go 43.93% <0.00%> (+0.45%) ⬆️
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/gitdiff/gitdiff.go 73.65% <0.00%> (+1.41%) ⬆️
modules/charset/charset.go 73.73% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e1039...0d609b5. Read the comment docs.

@zeripath zeripath merged commit ca0460b into go-gitea:master May 1, 2021
@KN4CK3R KN4CK3R deleted the refactor-test-ini branch May 7, 2021 06:25
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants