Skip to content

reverse #15734 partial and comment #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2021
Merged

reverse #15734 partial and comment #15740

merged 5 commits into from
May 6, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented May 5, 2021

as title

ref: #15734 (comment)

@6543 6543 requested review from KN4CK3R and zeripath May 5, 2021 20:45
@6543 6543 added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 5, 2021
@6543 6543 added this to the 1.15.0 milestone May 5, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2021
@6543 6543 mentioned this pull request May 5, 2021
Merged
zeripath
zeripath approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure that this should have already worked for #15730

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2021
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gimme back my redirects

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15740 (6acf1b6) into main (3088866) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15740      +/-   ##
==========================================
- Coverage   43.95%   43.94%   -0.01%     
==========================================
  Files         678      678              
  Lines       81908    81908              
==========================================
- Hits        36000    35998       -2     
  Misses      40037    40037              
- Partials     5871     5873       +2
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
modules/queue/workerpool.go 52.74% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3088866...6acf1b6. Read the comment docs.

@techknowlogick techknowlogick merged commit 6a3ad0b into go-gitea:main May 6, 2021
@6543 6543 deleted the reverse-15734-partial branch May 6, 2021 05:48
6543 added a commit to 6543-forks/gitea that referenced this pull request May 7, 2021
@6543 @zeripath
reverse go-gitea#15734 partial and comment (go-gitea#15740)
046c09e 
* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@6543 6543 mentioned this pull request May 7, 2021
Merged
techknowlogick pushed a commit that referenced this pull request May 7, 2021
@6543 @KN4CK3R @zeripath
Use pulls in commit graph unless pulls are disabled (#15734 & #15740 & …
7871094 
…#15774) (#15775)

* Commit Graph: Pull-Requests should not link to issues (#15734)

Use `/pulls` and simplify code.

* reverse #15734 partial and comment (#15740)

* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>

* Use pulls in commit graph unless pulls are disabled

Fix #15370

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: KN4CK3R <[email protected]>
Co-authored-by: zeripath <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @zeripath @AbdulrhmnGhanem
reverse go-gitea#15734 partial and comment (go-gitea#15740)
4f0e3a8 
* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <[email protected]>

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@zeripath zeripath zeripath approved these changes

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes

Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-commenter @KN4CK3R @zeripath @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @techknowlogick @GiteaBot