Skip to content

Add missing error to Doctor log #15813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2021
Merged

Add missing error to Doctor log #15813

merged 5 commits into from
May 10, 2021

Conversation

jolheiser
Copy link
Member

Minimal change, self-explanatory. But it is also fairly important context for the log.

Signed-off-by: jolheiser <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15813 (884a484) into main (3656a2a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15813      +/-   ##
==========================================
- Coverage   44.00%   44.00%   -0.01%     
==========================================
  Files         680      680              
  Lines       82212    82212              
==========================================
- Hits        36179    36177       -2     
  Misses      40128    40128              
- Partials     5905     5907       +2     
Impacted Files Coverage Δ
modules/doctor/dbversion.go 42.85% <0.00%> (ø)
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/queue/workerpool.go 52.74% <0.00%> (ø)
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3656a2a...884a484. Read the comment docs.

@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 2f65c6b into go-gitea:main May 10, 2021
jolheiser added a commit to jolheiser/gitea that referenced this pull request May 10, 2021
@jolheiser jolheiser added the backport/done All backports for this PR have been created label May 10, 2021
techknowlogick pushed a commit that referenced this pull request May 10, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants