Skip to content

Fix issue with checkbox checking and unicode #16148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jun 14, 2021

fix #16147

It would be better if goldmark could output the character position but it fixes the issue.

@KN4CK3R KN4CK3R added this to the 1.15.0 milestone Jun 14, 2021
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 14, 2021
@a1012112796 a1012112796 requested a review from silverwind June 14, 2021 14:37
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16148 (5a52c76) into main (15fbf23) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16148      +/-   ##
==========================================
+ Coverage   44.57%   44.60%   +0.02%     
==========================================
  Files         699      699              
  Lines       82765    82765              
==========================================
+ Hits        36896    36918      +22     
+ Misses      39888    39868      -20     
+ Partials     5981     5979       -2     
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 28.74% <0.00%> (+0.59%) ⬆️
modules/queue/workerpool.go 55.34% <0.00%> (+1.52%) ⬆️
modules/log/file.go 75.39% <0.00%> (+1.58%) ⬆️
modules/notification/mail/mail.go 40.00% <0.00%> (+2.10%) ⬆️
modules/queue/manager.go 68.36% <0.00%> (+2.82%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
services/mailer/mail_comment.go 85.18% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fbf23...5a52c76. Read the comment docs.

@6543 6543 merged commit 68503bf into go-gitea:main Jun 14, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 14, 2021
@KN4CK3R KN4CK3R deleted the fix-16147 branch June 15, 2021 06:13
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with checkbox checking and unicode
6 participants