Skip to content

Fix issue pasted image missing if no release permission #16520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 23, 2021

Fix the bug when a user has no release unit read permission, then all images pasted in issues will be missed.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.15 labels Jul 23, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 23, 2021
@6543 6543 added this to the 1.16.0 milestone Jul 23, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 23, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 23, 2021
@techknowlogick techknowlogick merged commit 9421bfe into go-gitea:main Jul 23, 2021
@lunny lunny deleted the lunny/fix_issue_image branch July 24, 2021 01:37
lunny added a commit to lunny/gitea that referenced this pull request Jul 24, 2021
* Fix issue pasted image missing if no release permission

* Update routers/web/web.go

Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
Co-authored-by: 6543 <[email protected]>
@lunny lunny added the backport/done All backports for this PR have been created label Jul 24, 2021
6543 added a commit that referenced this pull request Jul 24, 2021
)

* Fix issue pasted image missing if no release permission


Co-authored-by: zeripath <[email protected]>
Co-authored-by: 6543 <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* Fix issue pasted image missing if no release permission

* Update routers/web/web.go

Co-authored-by: zeripath <[email protected]>

Co-authored-by: zeripath <[email protected]>
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants