Download files to their original filename #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
sapk
reviewed
May 4, 2017
routers/repo/download.go
Outdated
| @@ -27,6 +28,7 @@ func ServeData(ctx *context.Context, name string, reader io.Reader) error { | |||
|
|
|||
| // Google Chrome dislike commas in filenames, so let's change it to a space | |||
| name = strings.Replace(name, ",", " ", -1) | |||
| name = path.Base(name) | |||
There was a problem hiding this comment.
If possible for little optimization, maybe do path.Base() before String.replace()
It could even be done like name = strings.Replace(path.Base(name), ",", " ", -1)
silverwind
force-pushed
the
download-filename
branch
from
54ba322 to
2ef6252
Compare
|
@sapk updated, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the path from download filenames, so
dir/file.txtnow downloads tofile.txtinstead ofdir-file.txt(browsers replace slashes with dashes).