Skip to content

fix: code review comments on mobile #17321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

kolaente
Copy link
Member

This PR fixes code review comments on mobile.

Before:

Screen Shot 2021-10-15 at 18 21 14

After:

Screen Shot 2021-10-15 at 19 06 38

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17321 (cba2486) into main (c5c88f2) will increase coverage by 0.04%.
The diff coverage is 64.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17321      +/-   ##
==========================================
+ Coverage   45.23%   45.27%   +0.04%     
==========================================
  Files         781      781              
  Lines       87811    87974     +163     
==========================================
+ Hits        39725    39834     +109     
- Misses      41620    41665      +45     
- Partials     6466     6475       +9     
Impacted Files Coverage Δ
modules/git/git.go 38.77% <0.00%> (-1.09%) ⬇️
modules/git/log_name_status.go 60.54% <0.00%> (-0.48%) ⬇️
modules/repository/adopt.go 0.00% <0.00%> (ø)
modules/setting/git.go 33.33% <ø> (ø)
modules/test/context_tests.go 68.18% <ø> (ø)
modules/web/route.go 80.19% <ø> (ø)
routers/web/repo/activity.go 29.23% <0.00%> (ø)
routers/web/repo/commit.go 27.30% <0.00%> (-0.43%) ⬇️
routers/web/user/auth.go 12.18% <0.00%> (ø)
services/forms/user_form.go 42.35% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b6805...cba2486. Read the comment docs.

@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Oct 16, 2021
@lunny lunny merged commit 6dd015a into go-gitea:main Oct 16, 2021
@kolaente kolaente deleted the fix/code-comment-mobile branch October 16, 2021 07:49
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants