Skip to content

Upgrade webpack to 5.59.1 to resolve the waitFor bug with watch-frontend #17428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 25, 2021

Webpack < 5.59 has a bug, which makes watch-frontend fail when editing .less files.

ERROR in ./web_src/less/index.less
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
Error: waitFor can only be called for an already started item
    at AsyncQueue.waitFor (/Users/user/work/gitea/node_modules/webpack/lib/util/AsyncQueue.js:180:5)
    at /Users/user/work/gitea/node_modules/webpack/lib/Compilation.js:4690:25
    at processQueue (/Users/user/work/gitea/node_modules/webpack/lib/util/processAsyncTree.js:50:4)
    at processTicksAndRejections (internal/process/task_queues.js:79:11)

Related webpack issues and PR:

https://github.com/webpack-contrib/mini-css-extract-plugin/issues/856
https://github.com/webpack/webpack/issues/14484
https://github.com/webpack/webpack/pull/14507

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 25, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Oct 25, 2021
@wxiaoguang wxiaoguang requested a review from silverwind October 25, 2021 10:29
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a961666). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17428   +/-   ##
=======================================
  Coverage        ?   45.39%           
=======================================
  Files           ?      791           
  Lines           ?    88674           
  Branches        ?        0           
=======================================
  Hits            ?    40255           
  Misses          ?    41906           
  Partials        ?     6513           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a961666...d53a116. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2021
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2021
@wxiaoguang wxiaoguang merged commit 649e1d0 into go-gitea:main Oct 25, 2021
@wxiaoguang wxiaoguang deleted the upgrade-webpack branch October 25, 2021 11:54
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…ontend` (go-gitea#17428)

Webpack < 5.59 has a bug, which makes watch-frontend fail when editing .less files.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants