-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add more random Avatar generators (DiceBear, Robot) and make it configurable #17701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can such feature be optional? I just worry if we introduce too many packages, the size of Gitea binary would become too big, sooner and sooner. And it seems that the random avatar can use the "gravatar" mechanism, just point the gravatar webserver to the DiceBear avatar server. |
the problem ... as is what you propose would be best to solve via #2222 whitch to not exist :/ |
Maybe #14799 can be easily fixed by a left-right mirror random avatar. |
Please have a look at: |
Should this be added as a second option or be closed since #17707 is merged? |
I'm for a second option since it does not add much to the size ... but asap we have a plugin system we should make both to plugins and fallback to the "default" avatar |
and about the svg lib: I'll also use that for other features ... like the request to be able to upload svg as profile image etc ... |
ps: the random generated DiceBear avatars have beard/braid, I think it's not suitable for a general purpose avatar generator before we know user's gender or preference. |
We could also use my library https://github.com/lafriks/go-avatars (it does generate png avatars also) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
Quote my question:
To avoid code bloat, do we really want to introduce new avatar generators? Could the avatars be provided by external gravatar servers instead of compiling code into Gitea? Although Gitea doesn't have a plugin system, the gravatar system is exactly for such case. |
before (0d05bdb): 84M (85384) so I think we can remove monsterid and wavatars but the rest should be good to go - and yes you can use gravatar like service but it will not be that fine granular & easy to do for selfhost admins |
To avoid bloating Gitea's code base, let users use their own avatar service (like self-maintained gavatar) to provide their customized avatars? After #17707 , nobody complains about |
I am cleaning stale/pending PRs, according to the discussion and vote above, I think this PR could be closed. |
DiceBear: https://codeberg.org/Codeberg/avatars
Robot: https://github.com/lafriks/go-avatars
None: use default images