Enable show more files in diff for git <2.31 #17733
Merged
+253
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately due to a misread on my behalf I missed that git diff only learned --skip-to in version 2.31.0. Thus this functionality was not working on older versions of git. This PR adds a handler that simply allows for us to skip reading the diffs until we find the correct file to skip to. Fix go-gitea#17731 Signed-off-by: Andrew Thornton <[email protected]>
Gusted
reviewed
Nov 19, 2021
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Nov 20, 2021
GiteaBot
added
lgtm/need 1
lunny
added
the
skip-changelog
Codecov Report
@@ Coverage Diff @@
## main #17733 +/- ##
=======================================
Coverage ? 45.52%
=======================================
Files ? 807
Lines ? 89824
Branches ? 0
=======================================
Hits ? 40894
Misses ? 42392
Partials ? 6538
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Thornton <[email protected]>
Gusted
approved these changes
Nov 20, 2021
GiteaBot
added
lgtm/done
|
Validated with Git version 2.18. |
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Unfortunately due to a misread on my behalf I missed that git diff only learned --skip-to in version 2.31.0. Thus this functionality was not working on older versions of git. This PR adds a handler that simply allows for us to skip reading the diffs until we find the correct file to skip to. Fix go-gitea#17731 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately due to a misread on my behalf I missed that git diff only learned
--skip-to in version 2.31.0. Thus this functionality was not working on older versions
of git.
This PR adds a handler that simply allows for us to skip reading the diffs until
we find the correct file to skip to.
Fix #17731
Signed-off-by: Andrew Thornton [email protected]