Skip to content

Use f variant to parse formatting #17751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 22, 2021

As title.
Related: https://drone.gitea.io/go-gitea/gitea/46990/3/6 (Check where the test fail)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2021
@techknowlogick techknowlogick added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 22, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Nov 22, 2021
@Gusted
Copy link
Contributor Author

Gusted commented Nov 22, 2021

@techknowlogick You've added the lgtm/need 1 label and removed the lgtm/done ;)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17751 (e29312a) into main (d710af6) will increase coverage by 0.03%.
The diff coverage is 51.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17751      +/-   ##
==========================================
+ Coverage   45.53%   45.57%   +0.03%     
==========================================
  Files         807      807              
  Lines       89828    89859      +31     
==========================================
+ Hits        40902    40951      +49     
+ Misses      42386    42370      -16     
+ Partials     6540     6538       -2     
Impacted Files Coverage Δ
routers/web/repo/commit.go 27.09% <0.00%> (-0.43%) ⬇️
services/gitdiff/gitdiff.go 73.70% <43.58%> (+0.61%) ⬆️
routers/web/repo/compare.go 44.42% <86.66%> (+0.90%) ⬆️
routers/web/repo/pull.go 30.54% <86.66%> (+0.60%) ⬆️
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/queue/workerpool.go 50.00% <0.00%> (-2.30%) ⬇️
models/issue_comment.go 52.97% <0.00%> (ø)
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e9228...e29312a. Read the comment docs.

@wxiaoguang wxiaoguang merged commit 7743f13 into go-gitea:main Nov 22, 2021
@techknowlogick
Copy link
Member

@Gusted a quirk of adding a label on the mobile app it seems, as it had the previous set cached when I added a specific label it sent the entire set that existed at the time I originally loaded which had the other LGTM label.

Giteabot resolves these things when the label is out of sync (usually, although sometimes it may take a comment for giteabot to update).

@Gusted Gusted deleted the correct-format branch November 24, 2021 08:27
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants