Skip to content

Some repository refactors #17950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2021
Merged

Some repository refactors #17950

merged 4 commits into from
Dec 12, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 10, 2021

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 10, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021 •
edited
Loading

Codecov Report

Merging #17950 (d50074b) into main (6d41729) will increase coverage by 0.01%.
The diff coverage is 46.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17950      +/-   ##
==========================================
+ Coverage   45.29%   45.31%   +0.01%     
==========================================
  Files         819      819              
  Lines       90846    90833      -13     
==========================================
+ Hits        41152    41163      +11     
+ Misses      43137    43119      -18     
+ Partials     6557     6551       -6
Impacted Files Coverage Δ
cmd/migrate_storage.go 0.00% <0.00%> (ø)
models/error.go 38.66% <ø> (-0.07%) ⬇️
models/org.go 76.92% <0.00%> (ø)
models/org_team.go 58.24% <0.00%> (ø)
models/repo_generate.go 24.00% <ø> (+9.00%) ⬆️
models/repo_permission.go 56.88% <0.00%> (-2.10%) ⬇️
models/statistic.go 0.00% <0.00%> (ø)
modules/repository/create.go 48.52% <0.00%> (ø)
modules/repository/generate.go 32.48% <0.00%> (ø)
modules/repository/init.go 57.74% <0.00%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7e832...d50074b. Read the comment docs.

KN4CK3R
KN4CK3R reviewed Dec 12, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2021
@lunny lunny force-pushed the lunny/some_refactors branch from 4753db4 to d50074b Compare December 12, 2021 15:24
@lunny lunny merged commit 5723240 into go-gitea:main Dec 12, 2021
@lunny lunny deleted the lunny/some_refactors branch December 12, 2021 15:48
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Some repository refactors (go-gitea#17950)
cb8b731 
* some repository refactors

* remove unnecessary code

* Fix test

* Remove unnecessary banner
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-commenter @silverwind @KN4CK3R @GiteaBot