Skip to content

Refactor admin user filter query parameters (#18965) #18975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Refactor admin user filter query parameters (#18965) #18975

merged 1 commit into from
Mar 2, 2022

Conversation

fnetX
Copy link
Contributor

@fnetX fnetX commented Mar 2, 2022

Backport #18965

Follows

https://github.com/go-gitea/gitea/pull/18957

Changes:

Only pass status_filter on admin page
Use a more general method to pass query parameters, remove hard-coded keys

Fix the strange URL:

https://try.gitea.io/explore/users?page=3&sort=alphabetically&q=&status_filter[is_active]=&status_filter[is_admin]=&status_filter[is_restricted]=&status_filter[is_2fa_enabled]=&status_filter[is_prohibit_login]=

Only pass `status_filter` on admin page
Use a more general method to pass query parameters, remove hard-coded keys
@6543 6543 added this to the 1.16.3 milestone Mar 2, 2022
@6543 6543 added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Mar 2, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 2, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2022
@6543 6543 merged commit 578f19a into go-gitea:release/v1.16 Mar 2, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants