-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix SecToTime edge-cases #20610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix SecToTime edge-cases #20610
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fbe1b0a
Fix SecToTime edge-cases
e266ad0
Merge branch 'main' into fix-sectime
a94e21a
Merge branch 'main' into fix-sectime
db4b4aa
Apply suggestions from code review
4727f0f
Merge branch 'main' into fix-sectime
d6468e1
Update modules/util/sec_to_time.go
073252a
Merge branch 'main' into fix-sectime
1d83cf0
Merge branch 'main' into fix-sectime
750b797
Fix tests
5e7e93f
Merge branch 'main' into fix-sectime
6543 6847342
Fix tests
529af45
Merge branch 'main' into fix-sectime
wxiaoguang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.