Skip to content

Make e-mail sanity check more precise #20991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 12, 2022
Merged

Make e-mail sanity check more precise #20991

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3a0440c
Make e-mail sanity check more precise
Aug 29, 2022
23073ad
Fixed unit tests
Aug 29, 2022
6b3aa28
Merge branch 'main' into fix-19897
balanceofcowards Aug 31, 2022
c7f105d
Merge branch 'main' into fix-19897
balanceofcowards Sep 1, 2022
8aab3a3
Merge branch 'main' into fix-19897
balanceofcowards Sep 4, 2022
2f94519
Merge branch 'main' into fix-19897
6543 Sep 14, 2022
e0960dd
Merge branch 'main' into fix-19897
6543 Sep 14, 2022
a6c22e1
Merge branch 'main' into fix-19897
balanceofcowards Sep 30, 2022
6ce3527
Merge branch 'main' into fix-19897
zeripath Oct 6, 2022
1f4624e
Merge branch 'main' into fix-19897
zeripath Oct 7, 2022
b049859
Merge branch 'main' into fix-19897
zeripath Oct 9, 2022
eccc6e2
Merge branch 'main' into fix-19897
zeripath Oct 11, 2022
4e80eab
Merge branch 'main' into fix-19897
techknowlogick Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions models/user/email_address.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func (err ErrEmailCharIsNotSupported) Error() string {
}

// ErrEmailInvalid represents an error where the email address does not comply with RFC 5322
// or has a leading '-' character
type ErrEmailInvalid struct {
Email string
}
Expand Down Expand Up @@ -134,9 +135,7 @@ func ValidateEmail(email string) error {
return ErrEmailCharIsNotSupported{email}
}

if !(email[0] >= 'a' && email[0] <= 'z') &&
!(email[0] >= 'A' && email[0] <= 'Z') &&
!(email[0] >= '0' && email[0] <= '9') {
if email[0] == '-' {
return ErrEmailInvalid{email}
}

Expand Down
36 changes: 19 additions & 17 deletions models/user/email_address_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,23 +281,25 @@ func TestEmailAddressValidate(t *testing.T) {
`[email protected]`: nil,
`first;[email protected]`: user_model.ErrEmailCharIsNotSupported{`first;[email protected]`},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"#[email protected]": user_model.ErrEmailInvalid{"#[email protected]"},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"%[email protected]": user_model.ErrEmailInvalid{"%[email protected]"},
"&[email protected]": user_model.ErrEmailInvalid{"&[email protected]"},
"'[email protected]": user_model.ErrEmailInvalid{"'[email protected]"},
"*[email protected]": user_model.ErrEmailInvalid{"*[email protected]"},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"/[email protected]": user_model.ErrEmailInvalid{"/[email protected]"},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"^[email protected]": user_model.ErrEmailInvalid{"^[email protected]"},
"`[email protected]": user_model.ErrEmailInvalid{"`[email protected]"},
"{[email protected]": user_model.ErrEmailInvalid{"{[email protected]"},
"|[email protected]": user_model.ErrEmailInvalid{"|[email protected]"},
"}[email protected]": user_model.ErrEmailInvalid{"}[email protected]"},
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"[email protected]": nil,
"#[email protected]": nil,
"[email protected]": nil,
"%[email protected]": nil,
"&[email protected]": nil,
"'[email protected]": nil,
"*[email protected]": nil,
"[email protected]": nil,
"[email protected]": user_model.ErrEmailInvalid{"[email protected]"},
"/[email protected]": nil,
"[email protected]": nil,
"[email protected]": nil,
"^[email protected]": nil,
"[email protected]": nil,
"`[email protected]": nil,
"{[email protected]": nil,
"|[email protected]": nil,
"}[email protected]": nil,
"[email protected]": nil,
";[email protected]": user_model.ErrEmailCharIsNotSupported{";[email protected]"},
"Foo <[email protected]>": user_model.ErrEmailCharIsNotSupported{"Foo <[email protected]>"},
string([]byte{0xE2, 0x84, 0xAA}): user_model.ErrEmailCharIsNotSupported{string([]byte{0xE2, 0x84, 0xAA})},
Expand Down