Switch from jest to vitest #21444
Merged
Switch from jest to vitest #21444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
the
skip-changelog
6543
approved these changes
Oct 13, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Oct 14, 2022
GiteaBot
added
lgtm/done
silverwind
commented
Oct 14, 2022
npm install: |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
|
6543
approved these changes
Oct 14, 2022
techknowlogick
pushed a commit
that referenced
this pull request
Oct 14, 2022
The vitest PR is merged, we can now add vitest to Gitpod's testing pane * #21444 We couldn't use jest in the same manner because we had to customize `NODE_OPTIONS`. Screenshot (look at all the cool stuff circled in red):  Signed-off-by: Yarden Shoham <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we are not bundling with
viteyet, we can usevitestin place of Jest which brings a few benefits like not requiring to useNODE_OPTIONSto run and having sane module resolution.It's possible to also use
jest-extendedwith vitest, but I opted to not do so for now because it brings heavyweight dependencies and it was trivial to just rewrite the affected matchers to be compatible.This PR also removes 153 JS dependencies, which is certainly nice.