Add more test for login links and fix a bug on action retrieve #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
reviewed
Aug 23, 2017
models/action.go
Outdated
| @@ -735,7 +735,7 @@ func GetFeeds(opts GetFeedsOptions) ([]*Action, error) { | |||
|
|
|||
| if opts.Collaborate { | |||
| cond = builder.Eq{"user_id": opts.RequestedUser.ID}.Or( | |||
| builder.Expr(`repo_id IN (SELECT repo_id FROM "access" WHERE access.user_id = ?)`, opts.RequestedUser.ID)) | |||
| builder.Expr("repo_id IN (SELECT repo_id FROM `access` WHERE access.user_id = ?)", opts.RequestedUser.ID)) | |||
There was a problem hiding this comment.
I find this bug via these tests.
|
There are conflicts now |
tboerger
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/login_links_test
branch
from
2f32ead to
cb73d0e
Compare
|
@lafriks rebased now. |
appleboy
approved these changes
Aug 23, 2017
|
LGTM |
tboerger
added
lgtm/need 1
|
Integration test failed |
lunny
force-pushed
the
lunny/login_links_test
branch
from
cb73d0e to
19ddfd0
Compare
|
LGTM |
tboerger
added
lgtm/done
Morlinest
reviewed
Sep 2, 2017
| } | ||
|
|
||
| reqAPI := NewRequestf(t, "GET", "/api/v1/users/%s/repos", userName) | ||
| respAPI := MakeRequest(t, reqAPI, http.StatusOK) |
There was a problem hiding this comment.
Shouldn't be here session.MakeRequest?
Morlinest
reviewed
Sep 2, 2017
|
|
||
| for _, repo := range apiRepos { | ||
| for _, link := range repoLinks { | ||
| req := NewRequest(t, "GET", fmt.Sprintf("/%s/%s%s", userName, repo.Name, link)) |
There was a problem hiding this comment.
NewRequestf instead of fmt.Sprintf?
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
The issue filter links should not be crawled by search engines, because they they only filter results, and contain nothing new, yet, they put a considerable load on the server. To stop - well behaving - search engines from following these links, add a `rel="nofollow"` property to them. The same property is already present on the archive download links, and plenty of other places. Fixes go-gitea#2361. Signed-off-by: Gergely Nagy <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.