Add tags list for repos whose release setting is disabled (#23465) #24369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3465) Close go-gitea#23427 Co-Author: @wxiaoguang If a repo's release setting is enabled, the logic has't changed. Clicking the "Tags" button will jump to `/{user}/{repo}/tags` and `templates/repo/release/list.tmpl` template will be used. <img src="https://user-images.githubusercontent.com/15528715/224939362-bd8974fd-08b0-4f79-a114-3389d15847ca.png" width="600px" /> If the release setting is disabled, clicking the "Tags" button will still jump to `/{user}/{repo}/tags` but a new template `templates/repo/tag/list.tmpl` will be used. <img src="https://user-images.githubusercontent.com/15528715/233834564-74741e49-f4e9-47c8-ac12-e306642798dc.png" width="600px" /> Since both templates above need to render the tags list, I moved the tags list to a shared template located in `templates/repo/tag/table.tmpl`. --------- Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: Giteabot <[email protected]>
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 27, 2023
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Apr 27, 2023
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Merged
techknowlogick
pushed a commit
that referenced
this pull request
Jul 5, 2023
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Jul 12, 2023
Fix go-gitea#25705 Regression of go-gitea#24369 There is no problem in 1.20 because there is go-gitea#24459 (cherry picked from commit 67d16c6)
|
We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. 🍵 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23465
Close #23427
Co-Author: @wxiaoguang
If a repo's release setting is enabled, the logic has't changed. Clicking the "Tags" button will jump to
/{user}/{repo}/tagsandtemplates/repo/release/list.tmpltemplate will be used.If the release setting is disabled, clicking the "Tags" button will still jump to
/{user}/{repo}/tagsbut a new templatetemplates/repo/tag/list.tmplwill be used.Since both templates above need to render the tags list, I moved the tags list to a shared template located in
templates/repo/tag/table.tmpl.