Skip to content

Fix loading state regression in markup content #25349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Fix loading state regression in markup content #25349

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9fee3c9
Fix loading state regression in markup content
silverwind Jun 18, 2023
cc9219e
fix regression
silverwind Jun 18, 2023
6113234
restore previous small border on inline math
silverwind Jun 18, 2023
d5d185e
simplify selector
silverwind Jun 18, 2023
e09ae5c
Merge branch 'main' into load
GiteaBot Jun 19, 2023
51c69d0
restart ci
silverwind Jun 19, 2023
903c544
Merge branch 'main' into load
GiteaBot Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion web_src/css/modules/animations.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
position: absolute;
display: block;
height: 4rem;
max-height: 50%;
aspect-ratio: 1 / 1;
left: 50%;
top: 50%;
max-height: 100%;
max-width: 100%;
transform: translate(-50%, -50%);
animation: isloadingspin 500ms infinite linear;
border-width: 4px;
Expand All @@ -40,6 +41,18 @@
height: var(--height-loading);
}

.markup .is-loading > * {
visibility: hidden;
}

.markup code.is-loading {
color: transparent;
}

.markup .is-loading {
background: transparent;
}

/* TODO: not needed, use "is-loading small-loading-icon" instead */
.btn-octicon.is-loading::after {
border-width: 2px;
Expand Down