Skip to content

Add actions/labeler #26962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 7, 2023
Merged

Add actions/labeler #26962

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7887dba
Add `actions/labeler`
silverwind Sep 7, 2023
e9d60cd
try an edit
silverwind Sep 7, 2023
0ed9d3c
tweak
silverwind Sep 7, 2023
e6a96d4
try on pull_request
silverwind Sep 7, 2023
7dc910a
revert to pull_request_target
silverwind Sep 7, 2023
f7dfb2d
add concurrency
silverwind Sep 7, 2023
be98baf
Update labeler.yml
techknowlogick Sep 7, 2023
9ac9d20
try types array
silverwind Sep 7, 2023
235be20
revert edit
silverwind Sep 7, 2023
5708889
add templates to ui and api label
silverwind Sep 7, 2023
c068899
add a few more
silverwind Sep 7, 2023
0dda37d
use 'dependencies'
silverwind Sep 7, 2023
7cd05c2
use full name
silverwind Sep 7, 2023
72654a7
remove dependencies for now
silverwind Sep 7, 2023
a8d851e
Update .github/labeler.yml
silverwind Sep 7, 2023
2045ec2
Update .github/labeler.yml
silverwind Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
kind/docs:
- docs/**/*

kind/ui:
- web_src/**/*
- all: ["templates/**/*", "!templates/swagger/v1_json.tmpl"]

kind/api:
- templates/swagger/v1_json.tmpl

kind/build:
- Makefile
- Dockerfile
- Dockerfile.rootless
- webpack.config.js

dependencies:
- go.mod
- go.sum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a PR imports a new module, this PR gets labeled as dependencies?

Copy link
Member Author

@silverwind silverwind Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, at least that's my understanding of the label. It says "Pull requests that update a dependency file". We can of course remove the setting of this label entirely if it's not useful, but I do see the addition/modification of depdendencies a important property on a PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the dependencies now for two reasons:

  • The label does not follow the kind/ prefix
  • I don't want to go overboard with label spam

- package.json
- package-lock.json
- pyproject.toml
- poetry.lock

kind/lint:
- .eslintrc.yaml
- .golangci.yml
- .markdownlint.yaml
- .spectral.yaml
- .stylelintrc.yaml
21 changes: 21 additions & 0 deletions .github/workflows/pull-labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: labeler

on:
pull_request_target:
types: [opened, synchronize, reopened]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
label:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/labeler@v4
with:
dot: true
sync-labels: true