-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Updating stale.yml to add the support for actions/stale
#27447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @a1012112796 , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stale action uses Github Actions instead of some stale bot. Probably you should add a cron job under .github/workflows
Yes I have added it as a cron job under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- delete the unnecessary file, comment, and KV pair
- fix CI failure
- don't be so rushed. On the first attempt, you asked for the review without knowing how stale action works, and on the second you asked for the review when the yaml file still has an indent error. Both mistakes are quite basic if you give them some attention. The reviewers will carry out their duties as usual, so there's no need to tag them in a hurry.
We're currently discussing a restructuring of our labels, so we should wait until it's done before merging this. Also I don't think we should close PRs. Give maintainers time, some of us go through the list regularly and try to review especially old PRs which have remained untouched for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason to use v3 instead of the current latest version v8?
The options in the docs seem to use '-' instead of the camel case. And some of the labels are not suited for our current label system.
9400a60
to
5516af8
Compare
ping @denyskon @go-gitea/technical-oversight-committee |
5516af8
to
dbceeea
Compare
I think those problems still exist. |
I'm not sure about this PR: |
Having been involved with projects using and not using a stalebot, I think my preference is also to not have one where possible. We have a lot of open issues, however I think many of the issues that could benefit from some automation (i.e. reported on much older versions) are already labeled such that this config will likely miss them. ( |
Since giteabot will close an issue which have |
I also think a stale bot won't be a benefit. |
Adding support for Actions/stale #27004