Skip to content

Updating stale.yml to add the support for actions/stale #27447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

gaurangkudale
Copy link

Adding support for Actions/stale #27004

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2023
@gaurangkudale
Copy link
Author

gaurangkudale commented Oct 4, 2023

Hi @a1012112796 ,
Can you please review this PR and let me know if there are any suggestions

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 5, 2023
Copy link
Member

@lng2020 lng2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stale action uses Github Actions instead of some stale bot. Probably you should add a cron job under .github/workflows

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2023
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Oct 5, 2023
@github-actions github-actions bot removed the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 5, 2023
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Oct 5, 2023
@gaurangkudale
Copy link
Author

The stale action uses Github Actions instead of some stale bot. Probably you should add a cron job under .github/workflows

Yes I have added it as a cron job under .github/workflows

Copy link
Member

@lng2020 lng2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. delete the unnecessary file, comment, and KV pair
  2. fix CI failure
  3. don't be so rushed. On the first attempt, you asked for the review without knowing how stale action works, and on the second you asked for the review when the yaml file still has an indent error. Both mistakes are quite basic if you give them some attention. The reviewers will carry out their duties as usual, so there's no need to tag them in a hurry.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 6, 2023
@denyskon
Copy link
Member

denyskon commented Oct 7, 2023

We're currently discussing a restructuring of our labels, so we should wait until it's done before merging this.

Also I don't think we should close PRs. Give maintainers time, some of us go through the list regularly and try to review especially old PRs which have remained untouched for a while.

@denyskon denyskon added status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR and removed status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Oct 7, 2023
Copy link
Member

@lng2020 lng2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason to use v3 instead of the current latest version v8?
The options in the docs seem to use '-' instead of the camel case. And some of the labels are not suited for our current label system.

@a1012112796
Copy link
Member

ping @denyskon @go-gitea/technical-oversight-committee

@lng2020
Copy link
Member

lng2020 commented Dec 8, 2023

Is there a particular reason to use v3 instead of the current latest version v8? The options in the docs seem to use '-' instead of the camel case. And some of the labels are not suited for our current label system.

I think those problems still exist.

@delvh
Copy link
Member

delvh commented Dec 8, 2023

I'm not sure about this PR:
On one hand, many issues become stale and cannot be reproduced in later versions.
However, from a user perspective I always hate it when I find my issue online, it is closed, and the reason for closing was inactivity.

@jolheiser
Copy link
Member

jolheiser commented Dec 8, 2023

Having been involved with projects using and not using a stalebot, I think my preference is also to not have one where possible.

We have a lot of open issues, however I think many of the issues that could benefit from some automation (i.e. reported on much older versions) are already labeled such that this config will likely miss them. (confirmed being the big one, as they were "confirmed" at the time but may no longer be relevant)

@lunny
Copy link
Member

lunny commented Dec 9, 2023

Since giteabot will close an issue which have issue/needs-feedback label with no reponse for a month. I think we can close this PR and even remove the old stale file.

@denyskon
Copy link
Member

denyskon commented Dec 9, 2023

I also think a stale bot won't be a benefit.

@lunny lunny closed this Dec 9, 2023
lafriks pushed a commit that referenced this pull request Dec 9, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants