Skip to content

Remove unused KeyID. #29167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2024
Merged

Remove unused KeyID. #29167

merged 3 commits into from
Feb 14, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Feb 14, 2024

KeyID is never set.

@KN4CK3R KN4CK3R added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 14, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2024
@KN4CK3R KN4CK3R added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 14, 2024
@techknowlogick techknowlogick merged commit 155269f into go-gitea:main Feb 14, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 14, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 14, 2024
@KN4CK3R KN4CK3R deleted the fix-key-id branch February 15, 2024 07:03
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 15, 2024
@KN4CK3R @silverwind
Remove unused KeyID. (go-gitea#29167)
ab33f41 
`KeyID` is never set.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@KN4CK3R @silverwind
Remove unused KeyID. (go-gitea#29167)
19e7828 
`KeyID` is never set.
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@KN4CK3R @earl-warren
Remove unused KeyID. (go-gitea#29167)
52ef33b 
`KeyID` is never set.

(cherry picked from commit 155269f)

Conflicts:
	models/user/email_address.go
	trivial context conflict
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@KN4CK3R @techknowlogick @wxiaoguang @delvh @GiteaBot