Fix incorrect tree path value for patch editor #29377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
backport/v1.21
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
lunny
approved these changes
Feb 25, 2024
GiteaBot
added
lgtm/need 1
lng2020
reviewed
Feb 26, 2024
| <input type="hidden" id="tree_path" name="tree_path" value="" required> | ||
| <input id="file-name" maxlength="500" type="hidden" value="diff.patch"> | ||
| <input type="hidden" name="tree_path" value="__dummy_for_EditRepoFileForm.TreePath(Required)__"> | ||
| <input id="file-name" type="hidden" value="diff.patch"> |
There was a problem hiding this comment.
Accidentally remove maxlength="500" after #29389 merged?
There was a problem hiding this comment.
It is removed intentionally.
It doesn't make sense to use maxlength for a hidden input.
lng2020
approved these changes
Feb 26, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 26, 2024
Regression of go-gitea#18718. When submitting the form, EditRepoFileForm.TreePath is marked as "Required", so the value can't be empty. The value is not used by backend, so use a meaningful dummy value for it.
GiteaBot
added
backport/done
wxiaoguang
added a commit
that referenced
this pull request
Feb 26, 2024
Backport #29377 by wxiaoguang Regression of #18718. When submitting the form, EditRepoFileForm.TreePath is marked as "Required", so the value can't be empty. The value is not used by backend, so use a meaningful dummy value for it. Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 27, 2024
* giteaofficial/main: Fix mail template error (go-gitea#29410) Document our issue locking policy (go-gitea#29433) Fix htmx rendering the login page in frame on session logout (go-gitea#29405) Ignore empty repo for CreateRepository in action notifier (go-gitea#29416) Fix incorrect tree path value for patch editor (go-gitea#29377) Fix logic error from go-gitea#28138 (go-gitea#29417)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of #18718. When submitting the form, EditRepoFileForm.TreePath is marked as "Required", so the value can't be empty. The value is not used by backend, so use a meaningful dummy value for it.