Skip to content

Fix/Improve processWindowErrorEvent #29407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 28, 2024
Merged

Fix/Improve processWindowErrorEvent #29407

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1bc9c27
Improve `processWindowErrorEvent`
silverwind Feb 26, 2024
913be69
rewrite the function, handle all cases
silverwind Feb 26, 2024
4c07e51
handle trailing dot in message
silverwind Feb 26, 2024
a2346aa
comment tweaks
silverwind Feb 26, 2024
9b2e79f
comment tweak
silverwind Feb 26, 2024
5ce63fb
Update web_src/js/bootstrap.js
silverwind Feb 26, 2024
25d1e1c
further simplify the handle to show error events only in development
silverwind Feb 27, 2024
ce860ca
tweak comment
silverwind Feb 27, 2024
c26fb35
Update web_src/js/bootstrap.js
silverwind Feb 27, 2024
3430adf
Update web_src/js/bootstrap.js
silverwind Feb 27, 2024
e8163f9
wrap comments at 100 chars
silverwind Feb 27, 2024
05f7132
Update web_src/js/bootstrap.js
silverwind Feb 27, 2024
c477203
add check for Error, output type directly, update comment
silverwind Feb 27, 2024
409fb81
restore renderedType
silverwind Feb 27, 2024
47bd4ec
Update web_src/js/bootstrap.js
silverwind Feb 28, 2024
146e955
Merge branch 'main' into errevent
GiteaBot Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web_src/js/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function processWindowErrorEvent(e) {
const assetBaseUrl = String(new URL(__webpack_public_path__, window.location.origin));

// error is likely from browser extension or inline script. Do not show these in production builds.
if (!err.stack?.includes(assetBaseUrl) && window.config?.runModeIsProd) return;
if (!err?.stack?.includes(assetBaseUrl) && window.config?.runModeIsProd) return;

let message;
if (e.type === 'unhandledrejection') {
Expand All @@ -49,6 +49,7 @@ function processWindowErrorEvent(e) {
}

showGlobalErrorMessage(`${message} Open browser console to see more details.`);
console.error(err ?? e);
}

function initGlobalErrorHandler() {
Expand Down