Skip to content

enhancement of compare feature #29766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Mar 13, 2024

splited from #25322

  • split branch/tags dropdown as two parts: repository dropdown and branch/tags dropdown. that's same with github.

image

  • user can search any repository in repository search box.

image
image

  • show a single error log instead of a 404 page when the head repo or user, the head or base ref is not exist. then user still can choose other option easyly.

image
image

splited from go-gitea#25322

- split branch/tags dropdownas two parts: repository
  dropdown and branch/tags dropdown. that's same
  with github.

- user can search any repository in repository search box.

- show a single error log instead of a 404 page when the
  head repo or user, the head or base ref is not exist.
  then user still can choose other option easyly.

Signed-off-by: a1012112796 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 13, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/frontend modifies/templates This PR modifies the template files modifies/js labels Mar 13, 2024
@a1012112796 a1012112796 added the type/enhancement An improvement of existing functionality label Mar 13, 2024
@silverwind
Copy link
Member

image

I think it's supposed to render like this, at least does so for me on current main:

image

@a1012112796
Copy link
Member Author

image I think it's supposed to render like this, at least does so for me on current main: image

fixed 94916db

@silverwind
Copy link
Member

Test failures related.

@silverwind
Copy link
Member

split branch/tags dropdown as two parts: repository dropdown and branch/tags dropdown. that's same with github.

Is there a condition when it shows 4 selection boxes or is it always?

Wondering because at least in some cases, github only shows 2 boxes, like here:

https://github.com/go-gitea/gitea/compare/release/v1.22

@a1012112796
Copy link
Member Author

Is there a condition when it shows 4 selection boxes or is it always?

to chose other repository easily. then the server can save time loading branch information for the all associated repository it uses. at last user can chose all repos by ui now.

Wondering because at least in some cases, github only shows 2 boxes, like here:

yes, in fact github provide two optional views, one has repo chose options, the others don't have, and user can switch it by click the 'compare across forks' buttuon. I has try it in #25322 also. but as lunny says (#25322 (comment)), looks the second view is not so necessary.

Signed-off-by: a1012112796 <[email protected]>
Signed-off-by: a1012112796 <[email protected]>
@lunny
Copy link
Member

lunny commented May 2, 2024

image Github has a link `compare across forks` to switch from 2 columns to 4 columns compare UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files modifies/translation type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants