Improve attachment upload methods #30513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

silverwind merged 15 commits into go-gitea:main from tyroneyeh:main_improve_paste_upload

Jun 27, 2024

Contributor

tyroneyeh commented Apr 16, 2024 •

edited by wxiaoguang

Loading

Use dropzone to handle file uploading for all cases, including pasting and dragging
Merge duplicate code, use consistent behavior for link generating

Close #20130


          Improve attachment upload methods

ce57452

GiteaBot added the lgtm/need 2 label

pull-request-size bot added the size/L label


          Fix js error in edit issue and improve image type check

48cf2a5

github-actions bot added the modifies/js label


          Fix cannot to paste text file

5af777b

silverwind reviewed

View reviewed changes

web_src/js/features/comp/ComboMarkdownEditor.js Outdated Show resolved Hide resolved

silverwind reviewed

View reviewed changes

web_src/js/features/comp/Paste.js Outdated Show resolved Hide resolved

silverwind reviewed

View reviewed changes

web_src/js/features/repo-issue-edit.js Outdated Show resolved Hide resolved

silverwind reviewed

View reviewed changes

web_src/js/utils/dom.js Outdated Show resolved Hide resolved

silverwind reviewed

View reviewed changes

web_src/js/utils/dom.js Outdated Show resolved Hide resolved

tyroneyeh and others added 3 commits

April 18, 2024 09:36


          Update web_src/js/features/comp/Paste.js

b7828ad

Co-authored-by: silverwind <[email protected]>


          Change extName to use utils.js extname

64cffdd


          Adjust js code

c552d09

wxiaoguang self-assigned this

Contributor

wxiaoguang commented Jun 17, 2024

Will take a look later (resolve the conflicts and do some improvements)

silverwind reviewed

View reviewed changes

web_src/js/utils/dom.js Outdated Show resolved Hide resolved


          Merge branch 'main' into main_improve_paste_upload

bb995be

# Conflicts:
#	web_src/js/features/common-global.js
#	web_src/js/features/comp/Paste.js
#	web_src/js/features/repo-issue-edit.js
#	web_src/js/features/repo-issue.js

pull-request-size bot added size/M and removed size/L labels

fix

8d45f2e

wxiaoguang force-pushed the main_improve_paste_upload branch from 50e67a1 to 8d45f2e Compare

June 24, 2024 03:28

wxiaoguang marked this pull request as draft

June 24, 2024 03:28

wxiaoguang changed the title ~~Improve attachment upload methods~~ WIP: Improve attachment upload methods

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view


          Merge branch 'main' into main_improve_paste_upload

15f2c3f

# Conflicts:
#	web_src/js/features/dropzone.js
#	web_src/js/features/repo-issue-edit.js

wxiaoguang force-pushed the main_improve_paste_upload branch from c0cd2fc to 5710e0f Compare

June 26, 2024 17:26

pull-request-size bot added size/L and removed size/M labels

wxiaoguang changed the title ~~WIP: Improve attachment upload methods~~ Improve attachment upload methods

silverwind reviewed

View reviewed changes

web_src/js/utils.js Outdated Show resolved Hide resolved

wxiaoguang and others added 2 commits

June 27, 2024 03:10


          Update web_src/js/utils.js

4c3bf58

Co-authored-by: silverwind <[email protected]>


          fix utils

1e730ea

wxiaoguang added type/enhancement type/refactoring labels

wxiaoguang added this to the 1.23.0 milestone

wxiaoguang force-pushed the main_improve_paste_upload branch from 2b55659 to 26e8c8c Compare

June 27, 2024 03:38


          merge duplicate code

c9d088d

wxiaoguang force-pushed the main_improve_paste_upload branch from 26e8c8c to c9d088d Compare

June 27, 2024 03:56

Contributor

wxiaoguang commented Jun 27, 2024

All done IMO

wxiaoguang approved these changes

View reviewed changes

GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels

silverwind reviewed

View reviewed changes

web_src/js/features/comp/EditorUpload.js Outdated Show resolved Hide resolved


          Update web_src/js/features/comp/EditorUpload.js

0c1e092

silverwind approved these changes

View reviewed changes

GiteaBot added lgtm/done and removed lgtm/need 1 labels

silverwind added the reviewed/wait-merge label

silverwind enabled auto-merge (squash)

June 27, 2024 08:41


          Merge branch 'main' into main_improve_paste_upload

5adfdfc

silverwind merged commit 9bc5552 into go-gitea:main

26 checks passed

GiteaBot removed the reviewed/wait-merge label

tyroneyeh deleted the main_improve_paste_upload branch

June 27, 2024 12:59

silverwind mentioned this pull request

Fix JS error with disabled attachment and easymde #31511

Merged

zjjhot added a commit to zjjhot/gitea that referenced this pull request


          Merge remote-tracking branch 'giteaofficial/main'

b9bbd74

* giteaofficial/main:
  Fix avatar radius problem on the new issue page (go-gitea#31506)
  Make toast support preventDuplicates (go-gitea#31501)
  Improve attachment upload methods (go-gitea#30513)

lunny pushed a commit that referenced this pull request


          Fix JS error with disabled attachment and easymde (#31511)

62b3738

Not sure if this is a regression from
#30513, but when attachments are
disabled, `this.dropzone` is null and the code had failed in
`initEasyMDEPaste` trying to access `dropzoneEl.dropzone`.

yp05327 mentioned this pull request

Paste image cannot convert to img tag in windows. #32039

Closed

go-gitea locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done modifies/js type/enhancement type/refactoring