Skip to content

Fix line-number and scroll bugs (#33094) #33095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 3, 2025

Partially backport #33094

Fix the scroll bug in issue/pr view page.

Fix a JS error when line number exceeds the max

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2025
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jan 3, 2025
@wxiaoguang wxiaoguang changed the title Refactor legacy line-number and scroll code (#33094) Fix line-number and scroll bugs (#33094) Jan 3, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2025
@lafriks lafriks merged commit fd28151 into go-gitea:release/v1.23 Jan 3, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the backport-line-number-scroll branch January 4, 2025 02:16
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants