Skip to content

Fix for UI broke when a repo is starred & watched (#3630) #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2018

Conversation

kolaente
Copy link
Member

Fixes #3630.

@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #3810 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3810      +/-   ##
=========================================
- Coverage   23.02%     23%   -0.02%     
=========================================
  Files         126     126              
  Lines       24894   24894              
=========================================
- Hits         5731    5728       -3     
- Misses      18287   18289       +2     
- Partials      876     877       +1
Impacted Files Coverage Δ
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ea370...441ae31. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 17, 2018
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 19, 2018
@lafriks lafriks added this to the 1.5.0 milestone Apr 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2018
@appleboy appleboy merged commit 7cc96de into go-gitea:master Apr 19, 2018
@kolaente kolaente deleted the 3630-ui-fix branch July 15, 2018 18:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"unstar" + "unwatch" breaks the UI
6 participants