Skip to content

Re-enable random avatar feature #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2018

Conversation

daviian
Copy link
Member

@daviian daviian commented May 18, 2018

PR fixes not usable random avatars because a check introduced to enable custom avatars made the code responsible for random avatars unreachable.

This behaviour was and is still noticeable in gogs as well.

Furthermore with this change the radio buttons in the avatar form are useable again.
But IMHO the avatar form should be refurbished to better communicate the available features and how to achieve them.

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #3988 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3988      +/-   ##
==========================================
- Coverage   20.08%   20.07%   -0.02%     
==========================================
  Files         151      151              
  Lines       29874    29874              
==========================================
- Hits         6000     5997       -3     
- Misses      22968    22970       +2     
- Partials      906      907       +1
Impacted Files Coverage Δ
routers/user/setting/profile.go 0% <0%> (ø) ⬆️
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917b964...073cbcf. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2018
@lafriks lafriks added this to the 1.5.0 milestone May 18, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2018
@lunny
Copy link
Member

lunny commented May 19, 2018

make L-G-T-M work

@lunny lunny merged commit 4475477 into go-gitea:master May 19, 2018
@daviian daviian deleted the bugfix/reenable-random-avatar branch May 19, 2018 16:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants