Move Screenshots to Bottom #4128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'above the fold' space is very important, it seems possibly wasted with screenshots which aren't legible without enlarging. This is a proposal to move them down.
Codecov Report
@@ Coverage Diff @@
## master #4128 +/- ##
=======================================
Coverage 19.97% 19.97%
=======================================
Files 153 153
Lines 30494 30494
=======================================
Hits 6091 6091
Misses 23489 23489
Partials 914 914Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
appleboy
approved these changes
Jun 5, 2018
bkcsoft
added
lgtm/need 1
daviian
approved these changes
Jun 5, 2018
bkcsoft
added
lgtm/done
axifive
approved these changes
Jun 5, 2018
jonasfranz
approved these changes
Jun 5, 2018
|
That's a good idea |
|
New to this community here - is there anything else I need to do to get this merged, or will it be handled from here on out? |
|
@benyanke No, the team members do that. If something else is needed, they will write about it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'above the fold' space is very important, it seems possibly wasted with screenshots which aren't legible without enlarging. Proposing to move them down with this PR.
Let's capitalize on this MS traffic!