Skip to content

Retry test-fixtures loading in case of transaction rollback #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2018
Merged

Retry test-fixtures loading in case of transaction rollback #5125

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc4776b
Retry test-fixtures loading in case of transaction rollback
Oct 19, 2018
e323a13
Merge branch 'master' into avoid-rollback
lafriks Oct 20, 2018
2c38df2
Merge branch 'master' into avoid-rollback
techknowlogick Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion models/test_fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,14 @@ func InitFixtures(helper testfixtures.Helper, dir string) (err error) {

// LoadFixtures load fixtures for a test database
func LoadFixtures() error {
return fixtures.Load()
var err error
// Database transaction conflicts could occur and result in ROLLBACK
// As a simple workaround, we just retry 5 times.
for i := 0; i < 5; i++ {
err = fixtures.Load()
if err == nil {
break
}
}
return err
}