Allow cross-repository dependencies on issues

models/issue.go

@@ -1834,7 +1834,7 @@ type DependencyInfo struct {
 // Get Blocked By Dependencies, aka all issues this issue is blocked by.
 func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*DependencyInfo, err error) {
 	err = e.Table("issue_dependency").
-		Select("issue.id, issue.repo_id, issue.index, issue.is_closed, issue.name").
+		Select("issue.*").
 		Join("INNER", "issue", "issue.id = issue_dependency.dependency_id").
 		Where("issue_id = ?", issue.ID).
 		Find(&issueDeps)
@@ -1857,7 +1857,7 @@ func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*DependencyI
 // Get Blocking Dependencies, aka all issues this issue blocks.
 func (issue *Issue) getBlockingDependencies(e Engine) (issueDeps []*DependencyInfo, err error) {
 	err = e.Table("issue_dependency").
-		Select("issue.id, issue.repo_id, issue.index, issue.is_closed, issue.name").
+		Select("issue.*").
 		Join("INNER", "issue", "issue.id = issue_dependency.issue_id").
 		Where("dependency_id = ?", issue.ID).
 		Find(&issueDeps)

routers/repo/issue_dependency.go

@@ -40,7 +40,7 @@ func AddDependency(ctx *context.Context) {
 	}
 
 	// Check if issue and dependency is the same
-	if dep.Index == issueIndex {
+	if dep.ID == issue.ID {
 		ctx.Flash.Error(ctx.Tr("repo.issues.dependency.add_error_same_issue"))
 		return
 	}