Skip to content

faq: mention EMAIL_DOMAIN_WHITELIST on allowing email domains #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 17, 2019

Conversation

Mikaela
Copy link
Contributor

@Mikaela Mikaela commented Sep 16, 2019

I wanted to only allow two domains related to two specific organisations and followed the FAQ and was confused until reading app.ini more closely and finding out that the FAQ was wrong.

Questions that aren't yet clear to me:

  • Why does this section talk about email domains, while it documented only OpenID? Should I move it to a separate section?
  • I didn't see any blacklist in app.ini, should I remove /block?

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #8198 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8198      +/-   ##
==========================================
+ Coverage    41.6%   41.61%   +<.01%     
==========================================
  Files         483      483              
  Lines       64741    64741              
==========================================
+ Hits        26937    26940       +3     
+ Misses      34355    34354       -1     
+ Partials     3449     3447       -2
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 74.14% <0%> (+0.97%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a372363...829f3a3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 16, 2019
@jolheiser
Copy link
Member

Ah, that may have been an oversight. Thanks for the update!

  1. If you could move it into another sub-section, reference the [openid] section of the app.ini, and update the TOC, that would be great.
  2. Yes, for email whitelist you can remove the /block portion

@Mikaela
Copy link
Contributor Author

Mikaela commented Sep 16, 2019

Thanks for the fast response. Does this look OK (assuming the ToC update fixed the build)?

Also should I merge the commits or do you usually squash and merge?

Signed-off-by: Mikaela Suomalainen <[email protected]>
@Mikaela Mikaela force-pushed the faq-email-whitelist branch from 38c4003 to 4e3e847 Compare September 16, 2019 17:16
@Mikaela
Copy link
Contributor Author

Mikaela commented Sep 16, 2019

I don't understand what drone wishes me to do?

@jolheiser
Copy link
Member

It looks like the Drone issue is unrelated to this PR.

As for merging, we squash commits when we merge, so no worries.

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Sep 16, 2019
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the docs PR!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2019
@lunny lunny merged commit 0f08855 into go-gitea:master Sep 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@Mikaela Mikaela deleted the faq-email-whitelist branch February 15, 2022 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants