-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
faq: mention EMAIL_DOMAIN_WHITELIST on allowing email domains #8198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mikaela Suomalainen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8198 +/- ##
==========================================
+ Coverage 41.6% 41.61% +<.01%
==========================================
Files 483 483
Lines 64741 64741
==========================================
+ Hits 26937 26940 +3
+ Misses 34355 34354 -1
+ Partials 3449 3447 -2
Continue to review full report at Codecov.
|
Ah, that may have been an oversight. Thanks for the update!
|
Signed-off-by: Mikaela Suomalainen <[email protected]>
Thanks for the fast response. Does this look OK (assuming the ToC update fixed the build)? Also should I merge the commits or do you usually squash and merge? |
Signed-off-by: Mikaela Suomalainen <[email protected]>
38c4003
to
4e3e847
Compare
I don't understand what drone wishes me to do? |
It looks like the Drone issue is unrelated to this PR. As for merging, we squash commits when we merge, so no worries. |
Co-Authored-By: John Olheiser <[email protected]>
Co-Authored-By: John Olheiser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the docs PR!
I wanted to only allow two domains related to two specific organisations and followed the FAQ and was confused until reading
app.ini
more closely and finding out that the FAQ was wrong.Questions that aren't yet clear to me:
app.ini
, should I remove/block
?