Combine Drone release steps

[silverwind]

See #9324. I don't know if this will fix the issue but it seems worth a try to land this on master just to watch the release-master task run. If it does not work out, we can revert it.

[codecov-io]

Codecov Report

Merging #9338 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9338      +/-   ##
==========================================
- Coverage   41.42%   41.41%   -0.01%     
==========================================
  Files         568      568              
  Lines       74045    74045              
==========================================
- Hits        30671    30669       -2     
- Misses      39547    39552       +5     
+ Partials     3827     3824       -3

Impacted Files	Coverage Δ
modules/indexer/code/indexer.go	44.73% <0%> (-10.53%)	⬇️
modules/process/manager.go	74.69% <0%> (-3.62%)	⬇️
services/pull/check.go	55.3% <0%> (-2.28%)	⬇️
models/gpg_key.go	55.59% <0%> (+0.55%)	⬆️
models/repo_list.go	74.07% <0%> (+0.92%)	⬆️
modules/log/file.go	77.62% <0%> (+2.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b31c8...d693e47. Read the comment docs.

[lafriks]

I don't see how this does change things as checked out directory are shared between steps except if there are not in the same pipeline. Also imho js/css build step should be in different drone step

[silverwind]

Yes, they should be shared but the only logical explanation for #9324 is that they aren't for some reason.

I do think it should be possible to produce a working release locally via make release and not only via CI, so I see the release task dependencies as must-haves (minus GPG sign currently, but that could also be moved to make).

[techknowlogick]

So embedding works (we can see this with vendor'd css/js, as well as templates are embedded, this means go generate with bindata env is working.

I'm hesitant to merge this without testing, luckily drone allows us to run specific pipelines via CLI. I will test this change via CLI (which will allow me to also put in some debugging into drone that'll show more info (ex. ls of a specific dir before running make release)

Edit: woops. I had this page loaded up before your most recent comment @silverwind, I had same thought except after you :)

[zeripath]

This change means we lose testing on node10 doesn't it?

[techknowlogick]

Just ran drone exec --pipeline release-master with the changes I suggested to this PR and it builds as expected.

Thank you for this PR @silverwind :)

[techknowlogick]

@zeripath nope, this is just for the release steps, the node10 container is still in the testing pipeline.

[axifive]

@techknowlogick Can you also debug an existing step in master? To understand why it's not worked, maybe this can help avoid similar errors in the future.

[techknowlogick]

Oh, I know what's going on! I can't believe I missed it. The build & static step are run at the same time, this means that even though the files exist where they should, the go generate command ends up being run before the JS/CSS files are finished being generated. the "depends_on" needs to be removed from each step in the release pipelines to force each step to be run in sequence.

[techknowlogick]

Blocking per my most recent comment.

[silverwind]

@techknowlogick thanks for finding it. It's now clear to me that as soon as a depends_on is introduced, drone will parallelize (https://docker-runner.docs.drone.io/configuration/parallelism/). I went ahead and removed all depends_on in the release pipelines so they should now always serialize.

[silverwind]

Squashed and added new commit message.

[silverwind]

One more tweak pushed which make js css dependencies of generate. This fixes the case wheremake generate build (which some people have in their build scripts) would result in generate running only once and too early.

[silverwind]

One more tweak: Removed useless go-all target. Now go-check only runs once instead of twice and before generate.

The go target could potentially also be removed but I kept it because it allows for quicker building without generate. Thought, the same could also be achieved using make gitea.

[silverwind]

go target removed as well for simplicity's sake. One can still run make gitea (make gitea.exe on Windows) to achieve the same.

[techknowlogick]

Thanks @silverwind for all of your work on this :)