Skip to content

Test with 1.21 instead of 1.21.0 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Test with 1.21 instead of 1.21.0 #169

merged 1 commit into from
May 2, 2025

Conversation

jmr
Copy link
Collaborator

@jmr jmr commented May 2, 2025

I'm assuming this will get us the latest 1.21 release (currently 1.21.13) instead of 1.21.0.

https://go.dev/doc/devel/release#go1.21.minor

Add comments for when to update version based on discussion in #154

@jmr jmr force-pushed the versions branch 2 times, most recently from 20decad to b583241 Compare May 2, 2025 11:13
This will test with the latest 1.21 release (currently 1.21.13) instead
of 1.21.0.

https://go.dev/doc/devel/release#go1.21.minor

Add comments for when to update version based on discussion in
golang#154
@jmr jmr requested review from panmari and flwyd May 2, 2025 11:16
@panmari
Copy link
Collaborator

panmari commented May 2, 2025

Logs confirm that this uses now 1.21.13:

Setup go version spec 1.21
Found in cache @ /opt/hostedtoolcache/go/1.21.13/x64
Added go to the path
Successfully set up Go version 1.21

@panmari panmari merged commit 0a52ac3 into golang:master May 2, 2025
5 checks passed
abhinavdangeti pushed a commit to blevesearch/geo that referenced this pull request May 8, 2025
I'm assuming this will get us the latest 1.21 release (currently
1.21.13) instead of 1.21.0.

https://go.dev/doc/devel/release#go1.21.minor

Add comments for when to update version based on discussion in
golang#154
abhinavdangeti added a commit to blevesearch/geo that referenced this pull request May 12, 2025
Brings in all commits as of May 05, 2025:
```
* 4cab8bf dependabot[bot] | build(deps): bump golangci/golangci-lint-action from 7.0.0 to 8.0.0 and golangci-lint from v2.0 to v2.1 (golang#173)
* c498f45 Robert Snedegar | builder_snapper: Update constants and comments (golang#172)
* 18783dd Robert Snedegar | Update README.md and add CONTRIBUTING.md (golang#171)
* 9edba9f dependabot[bot] | build(deps): bump github/codeql-action from 3.28.16 to 3.28.17 (golang#170)
* 686492e Jesse Rosenstock | Test with 1.21 instead of 1.21.0 (golang#169)
* 29adb2f Panmari | Run tests on a matrix of go versions (golang#168)
* 6580a94 Robert Snedegar | Add missing methods on Edge (golang#166)
* 0738b43 Robert Snedegar | Fix Loop contains  which contained a missing negation and add test cases. (golang#156)
* a9f12e8 dependabot[bot] | build(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (golang#164)
* 8f26a2e Alan Strohm | go.yml: use stable go-version (golang#162)
* 7fd717b cui fliter | all: fix some comments (golang#161)
* 8769abd Robert Snedegar | Update scorecard.yml with full version comment on Upload to code-scan… (golang#160)
* 5905ce1 dependabot[bot] | build(deps): bump github/codeql-action from 3.28.13 to 3.28.15 (golang#159)
* a33ded6 dependabot[bot] | build(deps): bump actions/upload-artifact from 4.6.1 to 4.6.2 (golang#158)
* 5859d1c StepSecurity Bot | [StepSecurity] Apply security best practices (golang#155)
* b9a2fb8 Robert Snedegar | Fix identified linter errors preventing errorlint, exhaustive, inamedparam, and staticcheck from running and enable those checks. (golang#153)
```

---------

Signed-off-by: StepSecurity Bot <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: cuishuang <[email protected]>
Co-authored-by: Robert Snedegar <[email protected]>
Co-authored-by: Alan Strohm <[email protected]>
Co-authored-by: StepSecurity Bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: cui fliter <[email protected]>
Co-authored-by: Panmari <[email protected]>
Co-authored-by: Jesse Rosenstock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants