Skip to content

x/crypto/ssh/terminal: move all APIs to x/term and deprecate #31044

Closed
@tandr

Description

@tandr

What version of Go are you using (go version)?

$ go version
go version go1.12.1 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
not important

What did you do?

import (
	"os"
	"golang.org/x/crypto/ssh/terminal"
)

// abridged version
func checkIsTerminal(fd *osFile) bool {
	if fd != nil {
		return terminal.IsTerminal(int(fd.Fd()))
	}
	return false
}

What did you expect to see?

no "crypto" or "ssh" wording in import directive - there is nothing is going on what is cryptography-related

What did you see instead?

Since it has "crypto" part in a path, we have to explain to our legal department what do we do here, why do we need it, and how it affects whole solution software export restrictions.

It would be nice to have non-crypto and non-password related parts to be moved into library that has nothing to do with "crypto" or "ssh", as it definitely has more utility than just for ssh-related work.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions