Skip to content

vendor: review inclusion of x/sys/cpu #32102

Closed
@mundaym

Description

@mundaym

@rsc said in #24843 (comment):

  • for code vendored from x/crypto into standard library, change it during import to use internal/cpu, not x/sys/cpu
  • x/sys must not be vendored into the main tree

However it looks like it has now been vendored into std as of CL 164623.

My only real concern with this is that AFAICT x/sys/cpu doesn't contain the same options as internal/cpu to manually enable/disable CPU features using an environment variable.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsDecisionFeedback is required from experts, contributors, and/or the community before a change can be made.release-blocker

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions