go/build: Context.WorkingDir should just be Dir

[rsc]

CL 203820 introduced Context.WorkingDir but I don't see the API review anywhere.
It seems like it should just be "Dir".
We don't use the terminology "working dir" anywhere.

[rsc]

See also #36167.

[dmitshur]

/cc @bcmills @jayconrod

[bcmills]

I chose WorkingDir because Dir seemed a bit ambiguous, particularly given the ImportDir method. That said, I don't have a strong preference either way.

(@griesemer and @jayconrod reviewed the original CL.)

I'll send some changes to switch it to Dir.

[bcmills]

FWIW, I think I had picked up the name WorkingDir from x/tools/internal/imports, introduced in CL 158437.

Note also https://tip.golang.org/cmd/internal/objabi/#WorkingDir.

Admittedly, both of those are in internal packages.

[gopherbot]

Change https://golang.org/cl/211599 mentions this issue: internal/imports: set the Dir field on the build.Context (instead of WorkingDir) if present

[gopherbot]

Change https://golang.org/cl/211657 mentions this issue: go/build: rename WorkingDir to Dir